Exclude "openapi.merged.json" from built .sdist and .whl distributions #52908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file might be a left-over from earlier api generation and it is already .gitignored, so it does not appear in the source tarball, but sdist and wheel generation does not look at .gitignored files (for a good reason - we might want to include some generated files in those distributions) - so we should exclude it manually similarly as we already do with node_modules for example.
potiuk
requested review from
amoghrajesh,
ephraimbuddy,
gopidesupavan,
jedcunningham and
kaxil
eladkal
approved these changes
Jul 5, 2025
jscheffl
approved these changes
Jul 5, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Had the same reported last two times and am happy that this was not a local issue. Thanks for the fix!
jscheffl
added
the
backport-to-v3-1-test
amoghrajesh
approved these changes
Jul 5, 2025
kaxil
approved these changes
Jul 5, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jul 5, 2025
…distributions (#52908) The file might be a left-over from earlier api generation and it is already .gitignored, so it does not appear in the source tarball, but sdist and wheel generation does not look at .gitignored files (for a good reason - we might want to include some generated files in those distributions) - so we should exclude it manually similarly as we already do with node_modules for example. (cherry picked from commit 93f2bcc) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Backport successfully created: v3-0-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jul 5, 2025
…distributions (apache#52908) The file might be a left-over from earlier api generation and it is already .gitignored, so it does not appear in the source tarball, but sdist and wheel generation does not look at .gitignored files (for a good reason - we might want to include some generated files in those distributions) - so we should exclude it manually similarly as we already do with node_modules for example. (cherry picked from commit 93f2bcc) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
that referenced
this pull request
Jul 5, 2025
…distributions (#52908) (#52910) The file might be a left-over from earlier api generation and it is already .gitignored, so it does not appear in the source tarball, but sdist and wheel generation does not look at .gitignored files (for a good reason - we might want to include some generated files in those distributions) - so we should exclude it manually similarly as we already do with node_modules for example. (cherry picked from commit 93f2bcc) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
kaxil
pushed a commit
that referenced
this pull request
Jul 7, 2025
…distributions (#52908) (#52910) The file might be a left-over from earlier api generation and it is already .gitignored, so it does not appear in the source tarball, but sdist and wheel generation does not look at .gitignored files (for a good reason - we might want to include some generated files in those distributions) - so we should exclude it manually similarly as we already do with node_modules for example. (cherry picked from commit 93f2bcc) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
HsiuChuanHsu
pushed a commit
to HsiuChuanHsu/airflow
that referenced
this pull request
Jul 10, 2025
apache#52908) The file might be a left-over from earlier api generation and it is already .gitignored, so it does not appear in the source tarball, but sdist and wheel generation does not look at .gitignored files (for a good reason - we might want to include some generated files in those distributions) - so we should exclude it manually similarly as we already do with node_modules for example.
stephen-bracken
pushed a commit
to stephen-bracken/airflow
that referenced
this pull request
Jul 15, 2025
apache#52908) The file might be a left-over from earlier api generation and it is already .gitignored, so it does not appear in the source tarball, but sdist and wheel generation does not look at .gitignored files (for a good reason - we might want to include some generated files in those distributions) - so we should exclude it manually similarly as we already do with node_modules for example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file might be a left-over from earlier api generation and it is already .gitignored, so it does not appear in the source tarball, but sdist and wheel generation does not look at .gitignored files (for a good reason - we might want to include some generated files in those distributions) - so we should exclude it manually similarly as we already do with node_modules for example.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.