fix: Trim non-alphanumeric characters from the executor label #53534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubernetes label doesn't allow non-alphanumeric characters at the end of the values. With hybrid and custom executors, it's possible to have a long executor value. The last character can be special after the 63-character trimming.
LipuFei
requested review from
dstandish,
hussein-awala and
jedcunningham
as code owners
potiuk
approved these changes
Jul 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes label doesn't allow non-alphanumeric characters at the end of the values. With hybrid and custom executors, it's possible to have a long executor value. The last character can be non-alphanumeric after the 63-character trimming.