Skip to content

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Jul 23, 2025

Bringing #53340 back but only for removing Reserialized BaseOp.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@kaxil
Copy link
Member Author

kaxil commented Jul 23, 2025

Still needed for roundtrip.

  FAILED airflow-core/tests/unit/serialization/test_serialized_objects.py::test_serialized_dag_to_dict_and_from_dict_gives_same_result_in_tasks - TypeError: string indices must be integers
  FAILED airflow-core/tests/unit/serialization/test_serialized_objects.py::test_serialized_dag_get_run_data_interval[pre-AIP-39-should-infer] - AttributeError: 'LazyDeserializedDAG' object has no attribute '_real_dag'

@ashb
Copy link
Member

ashb commented Jul 28, 2025

Does that test make sense anymore? If it's only used in tests I don't think it's worth keeping around

@kaxil kaxil reopened this Aug 12, 2025
Bringing apache#53340 back but only for removing Reserialized BaseOp.
@kaxil kaxil force-pushed the remove-res10n-support branch from c5c14bc to 33ddaf6 Compare August 12, 2025 12:52
@kaxil
Copy link
Member Author

kaxil commented Aug 12, 2025

Does that test make sense anymore? If it's only used in tests I don't think it's worth keeping around

Yup, fixed it. ready for review again

@kaxil kaxil merged commit 5a4b490 into apache:main Aug 12, 2025
57 checks passed
@kaxil kaxil deleted the remove-res10n-support branch August 12, 2025 13:36
potiuk added a commit to potiuk/airflow that referenced this pull request Aug 12, 2025
@potiuk
Copy link
Member

potiuk commented Aug 12, 2025

This one broke main - not sure how but the tests pass when I revert it. #54420

ashb pushed a commit to potiuk/airflow that referenced this pull request Aug 12, 2025
gopidesupavan pushed a commit that referenced this pull request Aug 12, 2025
@kaxil
Copy link
Member Author

kaxil commented Aug 12, 2025

This one broke main - not sure how but the tests pass when I revert it. #54420

huh, no clue. Will try again tomorrow :)

@kaxil
Copy link
Member Author

kaxil commented Aug 12, 2025

Another attempt: #54428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants