Skip to content

Conversation

@kempspo
Copy link

@kempspo kempspo commented Aug 4, 2025

closes: #52254

During the migration in PR #50141, we lost several statistics related to task instances.

This PR hopes to add it back into the new task_runner.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@kaxil
Copy link
Member

kaxil commented Aug 13, 2025

closes: #52254

During the migration in PR #50141, we lost several statistics related to task instances.

This PR hopes to add it back into the new task_runner.

@kempspo It isn't related to #50141 but #43893. From Airflow 3.0 onwards, task are executed using Task SDK machinery. The issue to port metrics hasn't been worked on yet: #45511

@kempspo
Copy link
Author

kempspo commented Aug 13, 2025

@kaxil thanks for the context. It would be good to at least have a stopgap, though.

This is leaving my team blind from failures since we've upgraded to 3.0. (save for on failure callback, but IMO completely different mechanisms and workflows) . We've basically created some custom logic that looks at the meta db to do the same thing.

@kaxil
Copy link
Member

kaxil commented Aug 13, 2025

@kaxil thanks for the context. It would be good to at least have a stopgap, though.

This is leaving my team blind from failures since we've upgraded to 3.0. (save for on failure callback, but IMO completely different mechanisms and workflows) . We've basically created some custom logic that looks at the meta db to do the same thing.

I completely agree that we need metrics. Tests on this PR are failing. I haven't had a chance to review it right now, but I will do so later. Currently, I am cutting a release candidate for 3.0.5.

@ahidalgob
Copy link
Contributor

Is there a reason to add back ti_failures and operator_failures but not the *_successes ones?

Thank you!

@kempspo
Copy link
Author

kempspo commented Aug 26, 2025

@ahidalgob no, that was definitely not intentional.

@kaxil i'm happy to close this one out in favor of contributing to #45511

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Oct 11, 2025
@github-actions github-actions bot closed this Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:task-sdk stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Statistics not updated after failure

3 participants