Skip to content

Conversation

@guan404ming
Copy link
Member

Related Issue

#49741

Why

  • task group header is broken after api change
  • lack of clear TI function

How

  • fix header by passing correct param
image
  • implement clear TI in current implementation of Clear action
Screen.Recording.2025-08-10.at.4.18.43.PM.mov

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Aug 10, 2025
@guan404ming guan404ming changed the title Add clear TI for task group Add clear TI for task group page Aug 10, 2025
@guan404ming guan404ming changed the title Add clear TI for task group page Add clear TI for group task page Aug 10, 2025
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for the fix!

Just a nit: in airflow-core/src/airflow/ui/src/components/Clear/TaskInstance/ClearTaskInstanceButton.tsx:65 probably in case of a task group the button label must be changed to plural as there is probably in most cases more than one task instance to be cleared?

@guan404ming
Copy link
Member Author

Just a nit: in airflow-core/src/airflow/ui/src/components/Clear/TaskInstance/ClearTaskInstanceButton.tsx:65 probably in case of a task group the button label must be changed to plural as there is probably in most cases more than one task instance to be cleared?

Thanks for the review. That right, it would be better if we could dynamically change it. I've updated!

@bbovenzi
Copy link
Contributor

Closes #54361

@bbovenzi bbovenzi added this to the Airflow 3.0.5 milestone Aug 12, 2025
@uranusjr uranusjr mentioned this pull request Aug 13, 2025
2 tasks
@kaxil kaxil modified the milestones: Airflow 3.0.5, Airflow 3.1.0 Aug 13, 2025
@bbovenzi bbovenzi merged commit beef626 into apache:main Aug 14, 2025
53 checks passed
@guan404ming guan404ming deleted the fix-group-ti-header branch August 14, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants