-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Bump ruff to 0.12.8 everywhere #54317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bump ruff to the new version, also remove ruff from task-sdk codegen because "dev" dependency group that is automatically used when uv sync is run for development contains "apache-airflow-devel-common" that already has the ruff dependency. Any discrepancy leads to conflict so likely better to depend on the ruff version from devel-common everywhere.
6f70f27 to
857083c
Compare
|
BTW. WDYT @ashb @kaxil @amoghrajesh about moving the "generate_task_sdk_models.py" to I am working towards all distributions being really "standalone" i.e. except dependencies that are introduced by That would also simplify the generation step. Instaed of: We could have: Because Do you think it's a good idea ? |
|
@potiuk yes that is a good idea, and unless I am mistaken, it is already present in |
🤦 -> indeed the Stupid me :) |
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 74bdd3a v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
Bump ruff to the new version, also remove ruff from task-sdk codegen because "dev" dependency group that is automatically used when uv sync is run for development contains "apache-airflow-devel-common" that already has the ruff dependency. Any discrepancy leads to conflict so likely better to depend on the ruff version from devel-common everywhere. (cherry picked from commit 74bdd3a) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Bump ruff to the new version, also remove ruff from task-sdk codegen because "dev" dependency group that is automatically used when uv sync is run for development contains "apache-airflow-devel-common" that already has the ruff dependency. Any discrepancy leads to conflict so likely better to depend on the ruff version from devel-common everywhere. (cherry picked from commit 74bdd3a) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Bump ruff to the new version, also remove ruff from task-sdk codegen because "dev" dependency group that is automatically used when uv sync is run for development contains "apache-airflow-devel-common" that already has the ruff dependency. Any discrepancy leads to conflict so likely better to depend on the ruff version from devel-common everywhere. (cherry picked from commit 74bdd3a) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Bump ruff to the new version, also remove ruff from task-sdk codegen because "dev" dependency group that is automatically used when uv sync is run for development contains "apache-airflow-devel-common" that already has the ruff dependency. Any discrepancy leads to conflict so likely better to depend on the ruff version from devel-common everywhere.
Bump ruff to the new version, also remove ruff from task-sdk codegen because "dev" dependency group that is automatically used when uv sync is run for development contains "apache-airflow-devel-common" that already has the ruff dependency. Any discrepancy leads to conflict so likely better to depend on the ruff version from devel-common everywhere.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.