Fix speed of test_rtif_deletion_stale_data_error test #54542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was previously creating and running 40 tasks, when all we actually need to do is to put the DB in the state we expect (RTIF rows exist) and then run one task. This takes the test time form 31s down to 4s. This was tested that it still correctly tests the correct behaviour by removing the `session.flush()` that was added in the same change where this test was added, apache#42928 / ced319f.
potiuk
approved these changes
Aug 15, 2025
Member
|
Nice :) |
ashb
added
the
backport-to-v3-1-test
github-actions bot
pushed a commit
that referenced
this pull request
Aug 15, 2025
…4542) This test was previously creating and running 40 tasks, when all we actually need to do is to put the DB in the state we expect (RTIF rows exist) and then run one task. This takes the test time form 31s down to 4s. This was tested that it still correctly tests the correct behaviour by removing the `session.flush()` that was added in the same change where this test was added, #42928 / ced319f. (cherry picked from commit 5a411d7) Co-authored-by: Ash Berlin-Taylor <ash@apache.org>
Backport successfully created: v3-0-test
|
ashb
added a commit
that referenced
this pull request
Aug 15, 2025
…4542) (#54546) This test was previously creating and running 40 tasks, when all we actually need to do is to put the DB in the state we expect (RTIF rows exist) and then run one task. This takes the test time form 31s down to 4s. This was tested that it still correctly tests the correct behaviour by removing the `session.flush()` that was added in the same change where this test was added, #42928 / ced319f. (cherry picked from commit 5a411d7) Co-authored-by: Ash Berlin-Taylor <ash@apache.org>
kaxil
pushed a commit
that referenced
this pull request
Aug 18, 2025
…4542) (#54546) This test was previously creating and running 40 tasks, when all we actually need to do is to put the DB in the state we expect (RTIF rows exist) and then run one task. This takes the test time form 31s down to 4s. This was tested that it still correctly tests the correct behaviour by removing the `session.flush()` that was added in the same change where this test was added, #42928 / ced319f. (cherry picked from commit 5a411d7) Co-authored-by: Ash Berlin-Taylor <ash@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was previously creating and running 40 tasks, when all we actually
need to do is to put the DB in the state we expect (RTIF rows exist) and then
run one task. This takes the test time form 31s down to 4s.
This was tested that it still correctly tests the correct behaviour by
removing the
session.flush()that was added in the same change where thistest was added, #42928 / ced319f.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.