Skip to content

Conversation

@ashb
Copy link
Member

@ashb ashb commented Aug 18, 2025

(cherry picked from commit 1f4c55c)


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for 3.0.5, will revisit for 3.1

…from secrets backends (#54574)

(cherry picked from commit 1f4c55c)
@ashb ashb force-pushed the backport-1f4c55c-v3-0-test branch from ad7fa12 to 3440c38 Compare August 18, 2025 09:09
@ashb
Copy link
Member Author

ashb commented Aug 18, 2025

Oh nuts. THis is breaking on the trigger. And the main test unit tests didn't catch this :/

@potiuk
Copy link
Member

potiuk commented Aug 18, 2025

Oh nuts. THis is breaking on the trigger. And the main test unit tests didn't catch this :/

But why 🤔

@ashb
Copy link
Member Author

ashb commented Aug 18, 2025

Oh nuts. THis is breaking on the trigger. And the main test unit tests didn't catch this :/

But why 🤔

I haven't dug into the why yet, but it was totally missed on main, so I think something is wrong in the main tests (and since I ran the original tests with full-tests-needed it's not selective tests for once

@potiuk
Copy link
Member

potiuk commented Aug 18, 2025

I haven't dug into the why yet, but it was totally missed on main, so I think something is wrong in the main tests (and since I ran the original tests with full-tests-needed it's not selective tests for once

I think it's because of Python 3.9 missing in main.

@potiuk
Copy link
Member

potiuk commented Aug 18, 2025

I think it's because of Python 3.9 missing in main.

I am trying to verify that hypothesis now.

@ashb
Copy link
Member Author

ashb commented Aug 18, 2025

TY @potiuk -- I'm working on a new PR to fix the triggerer issue

@potiuk
Copy link
Member

potiuk commented Aug 18, 2025

BTW. It took some time to build 3.10 image for 3-0-test and it does not look it's Python version. The tests pass on main though - but likely you already know the reason :)

@ashb
Copy link
Member Author

ashb commented Aug 18, 2025

I don't know why the tests on main aren't covering this -- I suspect it's not a test that's gone wrong, but a test coverage issue somehow

@ashb
Copy link
Member Author

ashb commented Aug 18, 2025

Anyway, that trigger fix on main is #54612 -- once that is merged I'll cherry pick it in to this PR then manually merge them both.

…ers (#54612)

Somewhat annoyingly it has to be `sync_to_async(mask_secret)` but that is
unavoidable unfortunately.

Similar to #54574, but for the trigger.

(cherry picked from commit a2bd625)
@ashb ashb marked this pull request as draft August 18, 2025 12:55
@ashb
Copy link
Member Author

ashb commented Aug 18, 2025

(Made draft so we don't merge this one accidentally)

@kaxil kaxil marked this pull request as ready for review August 18, 2025 13:29
@kaxil
Copy link
Member

kaxil commented Aug 18, 2025

Tests green, undrafting and merging

@kaxil
Copy link
Member

kaxil commented Aug 18, 2025

Hmm tests have re-run after I un-drafted the PR 🤔

@kaxil
Copy link
Member

kaxil commented Aug 18, 2025

https://github.com/apache/airflow/actions/runs/17041173392 was the last run before I marked-it-ready

@ashb
Copy link
Member Author

ashb commented Aug 18, 2025

Manually merged and pushed as to v3-0-test as f3308d1

@ashb ashb closed this Aug 18, 2025
@ashb ashb deleted the backport-1f4c55c-v3-0-test branch August 18, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants