-
Notifications
You must be signed in to change notification settings - Fork 16.4k
[v3-0-test] TaskSDK: Make secrets masking work when conns are loaded from secrets backends (#54574) #54605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
amoghrajesh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good enough for 3.0.5, will revisit for 3.1
ad7fa12 to
3440c38
Compare
|
Oh nuts. THis is breaking on the trigger. And the main test unit tests didn't catch this :/ |
But why 🤔 |
I haven't dug into the why yet, but it was totally missed on main, so I think something is wrong in the main tests (and since I ran the original tests with full-tests-needed it's not selective tests for once |
I think it's because of Python 3.9 missing in main. |
I am trying to verify that hypothesis now. |
|
TY @potiuk -- I'm working on a new PR to fix the triggerer issue |
|
BTW. It took some time to build 3.10 image for 3-0-test and it does not look it's Python version. The tests pass on |
|
I don't know why the tests on main aren't covering this -- I suspect it's not a test that's gone wrong, but a test coverage issue somehow |
|
Anyway, that trigger fix on main is #54612 -- once that is merged I'll cherry pick it in to this PR then manually merge them both. |
|
(Made draft so we don't merge this one accidentally) |
|
Tests green, undrafting and merging |
|
Hmm tests have re-run after I un-drafted the PR 🤔 |
|
https://github.com/apache/airflow/actions/runs/17041173392 was the last run before I marked-it-ready |
|
Manually merged and pushed as to v3-0-test as f3308d1 |
(cherry picked from commit 1f4c55c)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.