Fix: Handle Kubernetes API responses with non-JSON bodies#55107
Merged
potiuk merged 1 commit intoapache:mainfrom Aug 31, 2025
Merged
Fix: Handle Kubernetes API responses with non-JSON bodies#55107potiuk merged 1 commit intoapache:mainfrom
potiuk merged 1 commit intoapache:mainfrom
Conversation
- Add robust JSON parsing with fallback for API exception bodies - Handle 429 responses and other cases where response body is plain text - Update KubernetesExecutor to safely parse ApiException.body - Update KubernetesInstallKueueOperator to handle non-JSON error bodies
HsiuChuanHsu
requested review from
hussein-awala and
jedcunningham
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
obarisk
reviewed
Aug 31, 2025
...iders/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the review! |
nothingmin
pushed a commit
to nothingmin/airflow
that referenced
this pull request
Sep 2, 2025
- Add robust JSON parsing with fallback for API exception bodies - Handle 429 responses and other cases where response body is plain text - Update KubernetesExecutor to safely parse ApiException.body - Update KubernetesInstallKueueOperator to handle non-JSON error bodies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Kubernetes API server's response body is not always guaranteed to be JSON. For example, in the case of a 429 (Too Many Requests) response, the body may be a plain string rather than JSON, causing json.loads() to fail with a JSONDecodeError.
https://github.com/kubernetes-client/python/blob/6e7c539f52dec4e993d2c32a4408920d8522f47e/kubernetes/base/dynamic/exceptions.py#L45C1-L77C1
This issue manifests in two key areas:
ApiExceptionduring task publishingFailToCreateErrorexceptionsChange Mades:
KubernetesExecutor (
kubernetes_executor.py):KubernetesInstallKueueOperator (
kueue.py):Closes
Fixes #49244
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.