Implement simpler and faster freeze check for translations #55154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

potiuk merged 1 commit into apache:main from potiuk:simpler-translation-freeze

Sep 6, 2025

Member

potiuk commented Sep 1, 2025

This is follow-up after #55119 - implements the translation freeze quite a bit simpler and faster:

uses selective checks (fail fast)
does not check the dates (we will set the flag to False when freeze time passes
you can bypass the freeze with a label rather than having to commit exemption file

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

potiuk requested review from amoghrajesh, ashb, bbovenzi, gopidesupavan, jedcunningham, jscheffl, pierrejeambrun, ryanahamilton and shubhamraj-git as code owners

September 1, 2025 16:36

boring-cyborg bot added area:dev-tools area:translations area:UI backport-to-v3-1-test translation:default labels

potiuk mentioned this pull request

Implement default language (English) freeze pre-commit #55119

Merged

Member Author

potiuk commented Sep 1, 2025

The failure is actually[ a demo how it will work:

First it failed (fast) with:

Screenshot 2025-09-01 at 18 38 01

Then I am going to add a label and close/reopen

potiuk added the allow translation change label

potiuk closed this

potiuk reopened this

Member Author

potiuk commented Sep 1, 2025

Now it nicely works after I set the label:

Screenshot 2025-09-01 at 18 40 20

potiuk requested a review from shahar1

September 1, 2025 16:41

shahar1 reviewed

View reviewed changes

dev/i18n/check_translations_completeness.py Show resolved Hide resolved

pierrejeambrun approved these changes

View reviewed changes

Member

pierrejeambrun left a comment •

edited

Loading

Nice improvement. (selective checks, flag + label)

dev/breeze/src/airflow_breeze/utils/selective_checks.py Outdated Show resolved Hide resolved

pierrejeambrun reviewed

View reviewed changes

Member

pierrejeambrun left a comment •

edited

Loading

I would expect the workflows files to be updated accordingly, am I missing something? (I guess I am, can't remember how that ui_english_translation_changed props is invoked)

potiuk force-pushed the simpler-translation-freeze branch 6 times, most recently from bb1cd5d to b25c05f Compare

September 4, 2025 00:25

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Implement simpler and faster freeze check for translations (apache#55154

b8bef1f

)

This is follow-up after apache#55119 - implements the translation freeze
quite a bit simpler and faster:

* uses selective checks (fail fast)
* does not check the dates (we will set the flag to False when freeze
  time passes
* you can bypass the freeze with a label rather than having to
  commit exemption file

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Do not fail when translation-changing commit runs as canary run (apac…

f65c389

…he#55325)

When we run with "translation-changing" commit in a canary run,
we should not fail the build as the change has already been
deliberately merged (likely with "allow translation changes" label).

Follow-up after apache#55154

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Implement simpler and faster freeze check for translations (apache#55154

b8f69f1

)

This is follow-up after apache#55119 - implements the translation freeze
quite a bit simpler and faster:

* uses selective checks (fail fast)
* does not check the dates (we will set the flag to False when freeze
  time passes
* you can bypass the freeze with a label rather than having to
  commit exemption file

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Do not fail when translation-changing commit runs as canary run (apac…

6d425cd

…he#55325)

When we run with "translation-changing" commit in a canary run,
we should not fail the build as the change has already been
deliberately merged (likely with "allow translation changes" label).

Follow-up after apache#55154

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Implement simpler and faster freeze check for translations (apache#55154

9959c10

)

This is follow-up after apache#55119 - implements the translation freeze
quite a bit simpler and faster:

* uses selective checks (fail fast)
* does not check the dates (we will set the flag to False when freeze
  time passes
* you can bypass the freeze with a label rather than having to
  commit exemption file

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Do not fail when translation-changing commit runs as canary run (apac…

719bb11

…he#55325)

When we run with "translation-changing" commit in a canary run,
we should not fail the build as the change has already been
deliberately merged (likely with "allow translation changes" label).

Follow-up after apache#55154

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Implement simpler and faster freeze check for translations (apache#55154

60cf601

)

This is follow-up after apache#55119 - implements the translation freeze
quite a bit simpler and faster:

* uses selective checks (fail fast)
* does not check the dates (we will set the flag to False when freeze
  time passes
* you can bypass the freeze with a label rather than having to
  commit exemption file

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Do not fail when translation-changing commit runs as canary run (apac…

713bd54

…he#55325)

When we run with "translation-changing" commit in a canary run,
we should not fail the build as the change has already been
deliberately merged (likely with "allow translation changes" label).

Follow-up after apache#55154

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Implement simpler and faster freeze check for translations (apache#55154

7e940c0

)

This is follow-up after apache#55119 - implements the translation freeze
quite a bit simpler and faster:

* uses selective checks (fail fast)
* does not check the dates (we will set the flag to False when freeze
  time passes
* you can bypass the freeze with a label rather than having to
  commit exemption file

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Do not fail when translation-changing commit runs as canary run (apac…

f086102

…he#55325)

When we run with "translation-changing" commit in a canary run,
we should not fail the build as the change has already been
deliberately merged (likely with "allow translation changes" label).

Follow-up after apache#55154

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Implement simpler and faster freeze check for translations (apache#55154

101b1c6

)

This is follow-up after apache#55119 - implements the translation freeze
quite a bit simpler and faster:

* uses selective checks (fail fast)
* does not check the dates (we will set the flag to False when freeze
  time passes
* you can bypass the freeze with a label rather than having to
  commit exemption file

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Do not fail when translation-changing commit runs as canary run (apac…

5e328ff

…he#55325)

When we run with "translation-changing" commit in a canary run,
we should not fail the build as the change has already been
deliberately merged (likely with "allow translation changes" label).

Follow-up after apache#55154

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Implement simpler and faster freeze check for translations (apache#55154

1b6f8ea

)

This is follow-up after apache#55119 - implements the translation freeze
quite a bit simpler and faster:

* uses selective checks (fail fast)
* does not check the dates (we will set the flag to False when freeze
  time passes
* you can bypass the freeze with a label rather than having to
  commit exemption file

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Do not fail when translation-changing commit runs as canary run (apac…

b627b2c

…he#55325)

When we run with "translation-changing" commit in a canary run,
we should not fail the build as the change has already been
deliberately merged (likely with "allow translation changes" label).

Follow-up after apache#55154

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Implement simpler and faster freeze check for translations (apache#55154

e3e0e65

)

This is follow-up after apache#55119 - implements the translation freeze
quite a bit simpler and faster:

* uses selective checks (fail fast)
* does not check the dates (we will set the flag to False when freeze
  time passes
* you can bypass the freeze with a label rather than having to
  commit exemption file

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Do not fail when translation-changing commit runs as canary run (apac…

79fb992

…he#55325)

When we run with "translation-changing" commit in a canary run,
we should not fail the build as the change has already been
deliberately merged (likely with "allow translation changes" label).

Follow-up after apache#55154

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Implement simpler and faster freeze check for translations (apache#55154

8efdf15

)

This is follow-up after apache#55119 - implements the translation freeze
quite a bit simpler and faster:

* uses selective checks (fail fast)
* does not check the dates (we will set the flag to False when freeze
  time passes
* you can bypass the freeze with a label rather than having to
  commit exemption file

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Do not fail when translation-changing commit runs as canary run (apac…

b64b08b

…he#55325)

When we run with "translation-changing" commit in a canary run,
we should not fail the build as the change has already been
deliberately merged (likely with "allow translation changes" label).

Follow-up after apache#55154

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Implement simpler and faster freeze check for translations (apache#55154

92a67dd

)

This is follow-up after apache#55119 - implements the translation freeze
quite a bit simpler and faster:

* uses selective checks (fail fast)
* does not check the dates (we will set the flag to False when freeze
  time passes
* you can bypass the freeze with a label rather than having to
  commit exemption file

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Do not fail when translation-changing commit runs as canary run (apac…

9de2668

…he#55325)

When we run with "translation-changing" commit in a canary run,
we should not fail the build as the change has already been
deliberately merged (likely with "allow translation changes" label).

Follow-up after apache#55154

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Implement simpler and faster freeze check for translations (apache#55154

6e89f48

)

This is follow-up after apache#55119 - implements the translation freeze
quite a bit simpler and faster:

* uses selective checks (fail fast)
* does not check the dates (we will set the flag to False when freeze
  time passes
* you can bypass the freeze with a label rather than having to
  commit exemption file

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Do not fail when translation-changing commit runs as canary run (apac…

5d85cc9

…he#55325)

When we run with "translation-changing" commit in a canary run,
we should not fail the build as the change has already been
deliberately merged (likely with "allow translation changes" label).

Follow-up after apache#55154

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Implement simpler and faster freeze check for translations (apache#55154

2849c12

)

This is follow-up after apache#55119 - implements the translation freeze
quite a bit simpler and faster:

* uses selective checks (fail fast)
* does not check the dates (we will set the flag to False when freeze
  time passes
* you can bypass the freeze with a label rather than having to
  commit exemption file

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Do not fail when translation-changing commit runs as canary run (apac…

1a42a75

…he#55325)

When we run with "translation-changing" commit in a canary run,
we should not fail the build as the change has already been
deliberately merged (likely with "allow translation changes" label).

Follow-up after apache#55154

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Implement simpler and faster freeze check for translations (apache#55154

66ff1a0

)

This is follow-up after apache#55119 - implements the translation freeze
quite a bit simpler and faster:

* uses selective checks (fail fast)
* does not check the dates (we will set the flag to False when freeze
  time passes
* you can bypass the freeze with a label rather than having to
  commit exemption file

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Do not fail when translation-changing commit runs as canary run (apac…

3f67c2e

…he#55325)

When we run with "translation-changing" commit in a canary run,
we should not fail the build as the change has already been
deliberately merged (likely with "allow translation changes" label).

Follow-up after apache#55154

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Implement simpler and faster freeze check for translations (apache#55154

741d14c

)

This is follow-up after apache#55119 - implements the translation freeze
quite a bit simpler and faster:

* uses selective checks (fail fast)
* does not check the dates (we will set the flag to False when freeze
  time passes
* you can bypass the freeze with a label rather than having to
  commit exemption file

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Do not fail when translation-changing commit runs as canary run (apac…

957aedc

…he#55325)

When we run with "translation-changing" commit in a canary run,
we should not fail the build as the change has already been
deliberately merged (likely with "allow translation changes" label).

Follow-up after apache#55154

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Implement simpler and faster freeze check for translations (apache#55154

2f550a6

)

This is follow-up after apache#55119 - implements the translation freeze
quite a bit simpler and faster:

* uses selective checks (fail fast)
* does not check the dates (we will set the flag to False when freeze
  time passes
* you can bypass the freeze with a label rather than having to
  commit exemption file

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request


          Do not fail when translation-changing commit runs as canary run (apac…

15b11b3

…he#55325)

When we run with "translation-changing" commit in a canary run,
we should not fail the build as the change has already been
deliberately merged (likely with "allow translation changes" label).

Follow-up after apache#55154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pierrejeambrun pierrejeambrun approved these changes

shahar1 shahar1 approved these changes

jscheffl jscheffl approved these changes

ashb Awaiting requested review from ashb ashb is a code owner

gopidesupavan Awaiting requested review from gopidesupavan gopidesupavan is a code owner

jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

amoghrajesh Awaiting requested review from amoghrajesh amoghrajesh is a code owner

bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner

Lee-W Awaiting requested review from Lee-W Lee-W is a code owner

jason810496 Awaiting requested review from jason810496 jason810496 is a code owner

eladkal Awaiting requested review from eladkal

romsharon98 Awaiting requested review from romsharon98 romsharon98 is a code owner

hussein-awala Awaiting requested review from hussein-awala hussein-awala is a code owner

Labels

allow translation change area:dev-tools area:translations area:UI backport-to-v3-1-test translation:default