-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Create Supervisor and comms for trigger in dag.test #55236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Supervisor and comms for trigger in dag.test #55236
Conversation
kaxil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks about right
When running in dag.test we create a special in-process supervisor and comms for fetching conns, variables, etc. But we do not do the same when we run the triggers for deferred operators. Thus, they will fail to fetch connections.
1d57a80 to
1d36718
Compare
|
Okay, cleaned up the code a bit and then did some test runs and the triggers seem to be working correctly now! |
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
|
Just one test to fix :) |
When running in dag.test we create a special in-process supervisor and comms for fetching conns, variables, etc. But we do not do the same when we run the triggers for deferred operators. Thus, they will fail to fetch connections.
When running in dag.test we create a special in-process supervisor and comms for fetching conns, variables, etc. But we do not do the same when we run the triggers for deferred operators. Thus, they will fail to fetch connections.
When running in dag.test we create a special in-process supervisor and comms for fetching conns, variables, etc. But we do not do the same when we run the triggers for deferred operators. Thus, they will fail to fetch connections.
When running in dag.test we create a special in-process supervisor and comms for fetching conns, variables, etc. But we do not do the same when we run the triggers for deferred operators. Thus, they will fail to fetch connections.
When running in dag.test we create a special in-process supervisor and comms for fetching conns, variables, etc. But we do not do the same when we run the triggers for deferred operators. Thus, they will fail to fetch connections.
When running in dag.test we create a special in-process supervisor and comms for fetching conns, variables, etc. But we do not do the same when we run the triggers for deferred operators. Thus, they will fail to fetch connections.
When running in dag.test we create a special in-process supervisor and comms for fetching conns, variables, etc. But we do not do the same when we run the triggers for deferred operators. Thus, they will fail to fetch connections.
When running in dag.test we create a special in-process supervisor and comms for fetching conns, variables, etc. But we do not do the same when we run the triggers for deferred operators. Thus, they will fail to fetch connections.
When running in dag.test we create a special in-process supervisor and comms for fetching conns, variables, etc. But we do not do the same when we run the triggers for deferred operators. Thus, they will fail to fetch connections.
When running in dag.test we create a special in-process supervisor and comms for fetching conns, variables, etc. But we do not do the same when we run the triggers for deferred operators. Thus, they will fail to fetch connections.
When running in dag.test we create a special in-process supervisor and comms for fetching conns, variables, etc. But we do not do the same when we run the triggers for deferred operators. Thus, they will fail to fetch connections.
When running in dag.test we create a special in-process supervisor and comms for fetching conns, variables, etc. But we do not do the same when we run the triggers for deferred operators. Thus, they will fail to fetch connections.
When running in dag.test we create a special in-process supervisor and comms for fetching conns, variables, etc. But we do not do the same when we run the triggers for deferred operators. Thus, they will fail to fetch connections.
When running in dag.test we create a special in-process supervisor and comms for fetching conns, variables, etc. But we do not do the same when we run the triggers for deferred operators. Thus, they will fail to fetch connections.
When running in dag.test we create a special in-process supervisor and comms for fetching conns, variables, etc. But we do not do the same when we run the triggers for deferred operators. Thus, they will fail to fetch connections.
When running in dag.test we create a special in-process supervisor and comms for fetching conns, variables, etc. But we do not do the same when we run the triggers for deferred operators. Thus, they will fail to fetch connections.
When running in dag.test we create a special in-process supervisor and comms for fetching conns, variables, etc. But we do not do the same when we run the triggers for deferred operators. Thus, they will fail to fetch connections.
When running in dag.test we create a special in-process supervisor and comms for fetching conns, variables, etc. But we do not do the same when we run the triggers for deferred operators. Thus, they will fail to fetch connections.
When running in dag.test we create a special in-process supervisor and comms for fetching conns, variables, etc. But we do not do the same when we run the triggers for deferred operators. Thus, they will fail to fetch connections.
relates to #54692
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.