-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Fix KEDA query for Kubernetes Executor #55559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jscheffl
merged 2 commits into
apache:main
from
boschglobal:bugfix/fix-keda-query-for-kubernetes-executor
Sep 13, 2025
Merged
Fix KEDA query for Kubernetes Executor #55559
jscheffl
merged 2 commits into
apache:main
from
boschglobal:bugfix/fix-keda-query-for-kubernetes-executor
Sep 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
approved these changes
Sep 12, 2025
Contributor
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix. I assume the tests need to be adjusted
suman-himanshu
pushed a commit
to suman-himanshu/airflow
that referenced
this pull request
Sep 17, 2025
* Fix KEDA query for Kubernetes Executor * Adapt unit tests
Brunda10
pushed a commit
to Brunda10/airflow
that referenced
this pull request
Sep 17, 2025
* Fix KEDA query for Kubernetes Executor * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Sep 30, 2025
* Fix KEDA query for Kubernetes Executor * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
* Fix KEDA query for Kubernetes Executor * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
* Fix KEDA query for Kubernetes Executor * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
* Fix KEDA query for Kubernetes Executor * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
* Fix KEDA query for Kubernetes Executor * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
* Fix KEDA query for Kubernetes Executor * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
* Fix KEDA query for Kubernetes Executor * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
* Fix KEDA query for Kubernetes Executor * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
* Fix KEDA query for Kubernetes Executor * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
* Fix KEDA query for Kubernetes Executor * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
* Fix KEDA query for Kubernetes Executor * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
* Fix KEDA query for Kubernetes Executor * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
* Fix KEDA query for Kubernetes Executor * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
* Fix KEDA query for Kubernetes Executor * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
* Fix KEDA query for Kubernetes Executor * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
* Fix KEDA query for Kubernetes Executor * Adapt unit tests
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
* Fix KEDA query for Kubernetes Executor * Adapt unit tests
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We noticed that when using a comparison like the one below for a KEDA query there is an issue with null values. Comparisons using '!=' will not return any rows which are null.
https://modern-sql.com/caniuse/is-distinct-from
This becomes a problem if there are tasks in the task_instance table which have not explicitly set an executor (so they just use the default one). So the issue occurs if the CeleryExecutor is set as default executor and the Kubernetes executor is set as additional (non-default) executor.
Then task instances which are up to be executed by the Celery executor will not be considered by the KEDA query and KEDA will scale down the worker count to 0 - which means that tasks waiting to be executed by the Celery executor never be executed.
The SQL comparison using "IS DISTINCT FROM" includes null values. Like this the KEDA query also works if the Celery Executor is set as default executor and tasks do not explicitly set the Executor field.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.