Skip to content

Conversation

@wolfdn
Copy link
Contributor

@wolfdn wolfdn commented Sep 12, 2025

Description

We noticed that when using a comparison like the one below for a KEDA query there is an issue with null values. Comparisons using '!=' will not return any rows which are null.

https://modern-sql.com/caniuse/is-distinct-from

This becomes a problem if there are tasks in the task_instance table which have not explicitly set an executor (so they just use the default one). So the issue occurs if the CeleryExecutor is set as default executor and the Kubernetes executor is set as additional (non-default) executor.
Then task instances which are up to be executed by the Celery executor will not be considered by the KEDA query and KEDA will scale down the worker count to 0 - which means that tasks waiting to be executed by the Celery executor never be executed.

The SQL comparison using "IS DISTINCT FROM" includes null values. Like this the KEDA query also works if the Celery Executor is set as default executor and tasks do not explicitly set the Executor field.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. I assume the tests need to be adjusted

@jscheffl jscheffl merged commit f888c79 into apache:main Sep 13, 2025
76 checks passed
@jscheffl jscheffl added the type:bug-fix Changelog: Bug Fixes label Sep 13, 2025
suman-himanshu pushed a commit to suman-himanshu/airflow that referenced this pull request Sep 17, 2025
* Fix KEDA query for Kubernetes Executor

* Adapt unit tests
Brunda10 pushed a commit to Brunda10/airflow that referenced this pull request Sep 17, 2025
* Fix KEDA query for Kubernetes Executor

* Adapt unit tests
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Sep 30, 2025
* Fix KEDA query for Kubernetes Executor

* Adapt unit tests
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 1, 2025
* Fix KEDA query for Kubernetes Executor

* Adapt unit tests
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 2, 2025
* Fix KEDA query for Kubernetes Executor

* Adapt unit tests
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 3, 2025
* Fix KEDA query for Kubernetes Executor

* Adapt unit tests
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 4, 2025
* Fix KEDA query for Kubernetes Executor

* Adapt unit tests
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
* Fix KEDA query for Kubernetes Executor

* Adapt unit tests
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
* Fix KEDA query for Kubernetes Executor

* Adapt unit tests
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 7, 2025
* Fix KEDA query for Kubernetes Executor

* Adapt unit tests
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 8, 2025
* Fix KEDA query for Kubernetes Executor

* Adapt unit tests
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 9, 2025
* Fix KEDA query for Kubernetes Executor

* Adapt unit tests
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 10, 2025
* Fix KEDA query for Kubernetes Executor

* Adapt unit tests
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 11, 2025
* Fix KEDA query for Kubernetes Executor

* Adapt unit tests
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 12, 2025
* Fix KEDA query for Kubernetes Executor

* Adapt unit tests
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 14, 2025
* Fix KEDA query for Kubernetes Executor

* Adapt unit tests
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 15, 2025
* Fix KEDA query for Kubernetes Executor

* Adapt unit tests
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 17, 2025
* Fix KEDA query for Kubernetes Executor

* Adapt unit tests
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 19, 2025
* Fix KEDA query for Kubernetes Executor

* Adapt unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart type:bug-fix Changelog: Bug Fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants