[AIRFLOW-4935] Add method in the bigquery hook to list tables in a dataset#5566
[AIRFLOW-4935] Add method in the bigquery hook to list tables in a dataset#5566mik-laj merged 1 commit intoapache:masterfrom
Conversation
|
Could you write some unit tests for it? |
|
Hi, this hook method is a useful feature for our use case. I'm wondering are you still working on this PR? |
|
Yes I'm making some unit tests. It will be available soon.
Le mer. 24 juil. 2019 à 23:22, Zhengliang(Zane) <notifications@github.com>
a écrit :
… Hi, this hook method is a useful feature for our use case. I'm wondering
are you still working on this PR?
cc @criccomini <https://github.com/criccomini> @whynick1
<https://github.com/whynick1>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5566?email_source=notifications&email_token=AMS27S7SS2JJG2ZQIOIG5STQBDBYFA5CNFSM4IBWV2Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2XUZPA#issuecomment-514804924>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMS27S3CKWFWEOVWZTA42VTQBDBYFANCNFSM4IBWV2YQ>
.
|
|
@benjamingrenier any updates on this? |
|
I will finish it this week.
Le mar. 6 août 2019 à 00:01, Zhengliang(Zane) <notifications@github.com> a
écrit :
… @benjamingrenier <https://github.com/benjamingrenier> any updates on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5566?email_source=notifications&email_token=AMS27SYXNDYTXLQTQMYF2DTQDCPLVA5CNFSM4IBWV2Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3TGY4Q#issuecomment-518417522>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMS27S7RUV4K74BQRLFUBTTQDCPLVANCNFSM4IBWV2YQ>
.
|
|
Are you planning to continue working on this change? This week, I would like to deal with PR reviews related to GCP. I would be happy if you would respond to all comments |
|
Yes I will work on it this week. I try to resolve my docker errors to run unit-tests locally. |
|
Recently introduced a new development environment. have you tried them? we plan to create a new extension to improve GCP development. |
|
Can you do rebase, please? |
It's done. Ok for you ? |
|
Something is wrong with this PR. Too many commits. I'm on vacation now🇫🇷. I'll look at this on Friday. |
benjamingrenier
force-pushed
the
AIRFLOW-4935
branch
from
acd2c9f to
af4e3d4
Compare
|
I think it's all right. |
There was a problem hiding this comment.
| self.log.info(dataset_tables_list) |
I haven't seen it before, but it seems to me that there will be too much information in the logs.
There was a problem hiding this comment.
I will fix it soon. I prepare a commit with more unit tests too.
There was a problem hiding this comment.
Can you please remove the log before merge?
|
Hi. I made a change in the base class - GoogleCloudBaseHook. Your PR may need to be changed. Could you do rebase? Cheers Reference: |
There was a problem hiding this comment.
@benjamingrenier We are in the middle of moving hooks and operators from contrib to core. Is it possible to rebase (add more unittestss?) quickly so that we can merge the change before we move it?
There was a problem hiding this comment.
Can you please remove the log before merge?
benjamingrenier
force-pushed
the
AIRFLOW-4935
branch
from
af4e3d4 to
4973c51
Compare
Rebase done and unittests added |
benjamingrenier
force-pushed
the
AIRFLOW-4935
branch
from
4973c51 to
103769d
Compare
|
Hey @benjamingrenier -> I must ask for another rebase: (. |
|
OK, it will be done in some hours.
Le sam. 21 sept. 2019 à 21:02, Jarek Potiuk <notifications@github.com> a
écrit :
… Hey @benjamingrenier <https://github.com/benjamingrenier> -> I must ask
for another rebase: (.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5566?email_source=notifications&email_token=AMS27SZTN2LXLGSCAWBYJQDQKZVVFA5CNFSM4IBWV2Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7IXYLY#issuecomment-533822511>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMS27S57S27I6AJWWXX44HTQKZVVFANCNFSM4IBWV2YQ>
.
|
benjamingrenier
force-pushed
the
AIRFLOW-4935
branch
from
103769d to
e1d8ecd
Compare
Codecov Report
@@ Coverage Diff @@
## master #5566 +/- ##
==========================================
+ Coverage 79.93% 80.06% +0.13%
==========================================
Files 608 608
Lines 35030 35048 +18
==========================================
+ Hits 28000 28062 +62
+ Misses 7030 6986 -44
Continue to review full report at Codecov.
|
|
Someone can do the review ? |
|
I added this PR to the queue next week. I will try to review it as soon as possible. |
7 participants
Method
get_dataset_tables_listadded in the hook, permits to use a table prefix too.