Implement filters for Dag run #55735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
|
RoyLee1224
requested review from
bbovenzi,
bugraoz93,
ephraimbuddy,
jason810496,
jscheffl,
kaxil,
pierrejeambrun,
potiuk,
rawwar,
ryanahamilton and
shubhamraj-git
as code owners
RoyLee1224
changed the title
jason810496
reviewed
Sep 16, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Nice! Thanks for the PR!
LGTM on the API side and it would be nice to add the test in airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_dag_run.py to verify the new filters, thanks!
bbovenzi
reviewed
Sep 17, 2025
Contributor
|
If we're going to refactor the Filter UX then let's move all the filters in. We can follow the example from #55620 for select inputs. |
Contributor
Author
|
@bbovenzi Oh I didn't notice the select filters are done. I'm on it. |
Contributor
|
Let's also hold off on Dag Id until we have the pattern search instead: #55691 |
Contributor
Author
|
I'm also not sure about the best design for the |
bbovenzi
added
the
allow translation change
Contributor
|
Let's not do producing asset for now. We don't even have that on the DagRunResponse |
RoyLee1224
force-pushed
the
dag_run_filter
branch
from
5b64afc to
e94de02
Compare
Contributor
Author
Update:Moved all filters into |
feat: add filter for dag Version feat(api): Add duration filter for Dag runs feat(ui): implement duration filter for Dag runs feat(ui,api): implement conf_contains filter refactor(ui): move trigering user filter into filterbar refactor: Simplify JSON type detection for filtering fix(i18n): modify triggering user translation
test: modify duration test
fix(tests): Correct assignment in fixture fix: Correct tests for duration and conf_contains filters fix(test): using from_datetime_to_zulu_without_ms for end date fix(tests): Correct tuple assignment for in test setup
Contributor
Author
|
Fixed the |
jason810496
approved these changes
Sep 26, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Fixed the DagRun.duration hybrid property to support the SQLite dialect, which was causing the test failures. It now uses julianday() for calculations. CI should pass now!
Nice catch! Thanks for the fix.
LGTM on API side.
15 tasks
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
* feat(ui): implement filterbar for Dag run feat: add filter for dag Version feat(api): Add duration filter for Dag runs feat(ui): implement duration filter for Dag runs feat(ui,api): implement conf_contains filter refactor(ui): move trigering user filter into filterbar refactor: Simplify JSON type detection for filtering fix(i18n): modify triggering user translation * fix: resolve conflicts & move all filters into filterBar * test: Add test for duration and conf_contains filters test: modify duration test * fix(ui): Add icons and styled options to Dag runs select type filters fix(tests): Correct assignment in fixture fix: Correct tests for duration and conf_contains filters fix(test): using from_datetime_to_zulu_without_ms for end date fix(tests): Correct tuple assignment for in test setup * fix(tests): Correct datetime formatting and test expectations in dag_run API tests * fix(tests): Simplify conf_contains filter test patterns * test: using int for testing duration * fix(models): Make DagRun.duration property SQLite-compatible * fix(i18n): add duration translation keys
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
* feat(ui): implement filterbar for Dag run feat: add filter for dag Version feat(api): Add duration filter for Dag runs feat(ui): implement duration filter for Dag runs feat(ui,api): implement conf_contains filter refactor(ui): move trigering user filter into filterbar refactor: Simplify JSON type detection for filtering fix(i18n): modify triggering user translation * fix: resolve conflicts & move all filters into filterBar * test: Add test for duration and conf_contains filters test: modify duration test * fix(ui): Add icons and styled options to Dag runs select type filters fix(tests): Correct assignment in fixture fix: Correct tests for duration and conf_contains filters fix(test): using from_datetime_to_zulu_without_ms for end date fix(tests): Correct tuple assignment for in test setup * fix(tests): Correct datetime formatting and test expectations in dag_run API tests * fix(tests): Simplify conf_contains filter test patterns * test: using int for testing duration * fix(models): Make DagRun.duration property SQLite-compatible * fix(i18n): add duration translation keys
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
* feat(ui): implement filterbar for Dag run feat: add filter for dag Version feat(api): Add duration filter for Dag runs feat(ui): implement duration filter for Dag runs feat(ui,api): implement conf_contains filter refactor(ui): move trigering user filter into filterbar refactor: Simplify JSON type detection for filtering fix(i18n): modify triggering user translation * fix: resolve conflicts & move all filters into filterBar * test: Add test for duration and conf_contains filters test: modify duration test * fix(ui): Add icons and styled options to Dag runs select type filters fix(tests): Correct assignment in fixture fix: Correct tests for duration and conf_contains filters fix(test): using from_datetime_to_zulu_without_ms for end date fix(tests): Correct tuple assignment for in test setup * fix(tests): Correct datetime formatting and test expectations in dag_run API tests * fix(tests): Simplify conf_contains filter test patterns * test: using int for testing duration * fix(models): Make DagRun.duration property SQLite-compatible * fix(i18n): add duration translation keys
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
* feat(ui): implement filterbar for Dag run feat: add filter for dag Version feat(api): Add duration filter for Dag runs feat(ui): implement duration filter for Dag runs feat(ui,api): implement conf_contains filter refactor(ui): move trigering user filter into filterbar refactor: Simplify JSON type detection for filtering fix(i18n): modify triggering user translation * fix: resolve conflicts & move all filters into filterBar * test: Add test for duration and conf_contains filters test: modify duration test * fix(ui): Add icons and styled options to Dag runs select type filters fix(tests): Correct assignment in fixture fix: Correct tests for duration and conf_contains filters fix(test): using from_datetime_to_zulu_without_ms for end date fix(tests): Correct tuple assignment for in test setup * fix(tests): Correct datetime formatting and test expectations in dag_run API tests * fix(tests): Simplify conf_contains filter test patterns * test: using int for testing duration * fix(models): Make DagRun.duration property SQLite-compatible * fix(i18n): add duration translation keys
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
* feat(ui): implement filterbar for Dag run feat: add filter for dag Version feat(api): Add duration filter for Dag runs feat(ui): implement duration filter for Dag runs feat(ui,api): implement conf_contains filter refactor(ui): move trigering user filter into filterbar refactor: Simplify JSON type detection for filtering fix(i18n): modify triggering user translation * fix: resolve conflicts & move all filters into filterBar * test: Add test for duration and conf_contains filters test: modify duration test * fix(ui): Add icons and styled options to Dag runs select type filters fix(tests): Correct assignment in fixture fix: Correct tests for duration and conf_contains filters fix(test): using from_datetime_to_zulu_without_ms for end date fix(tests): Correct tuple assignment for in test setup * fix(tests): Correct datetime formatting and test expectations in dag_run API tests * fix(tests): Simplify conf_contains filter test patterns * test: using int for testing duration * fix(models): Make DagRun.duration property SQLite-compatible * fix(i18n): add duration translation keys
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
* feat(ui): implement filterbar for Dag run feat: add filter for dag Version feat(api): Add duration filter for Dag runs feat(ui): implement duration filter for Dag runs feat(ui,api): implement conf_contains filter refactor(ui): move trigering user filter into filterbar refactor: Simplify JSON type detection for filtering fix(i18n): modify triggering user translation * fix: resolve conflicts & move all filters into filterBar * test: Add test for duration and conf_contains filters test: modify duration test * fix(ui): Add icons and styled options to Dag runs select type filters fix(tests): Correct assignment in fixture fix: Correct tests for duration and conf_contains filters fix(test): using from_datetime_to_zulu_without_ms for end date fix(tests): Correct tuple assignment for in test setup * fix(tests): Correct datetime formatting and test expectations in dag_run API tests * fix(tests): Simplify conf_contains filter test patterns * test: using int for testing duration * fix(models): Make DagRun.duration property SQLite-compatible * fix(i18n): add duration translation keys
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
* feat(ui): implement filterbar for Dag run feat: add filter for dag Version feat(api): Add duration filter for Dag runs feat(ui): implement duration filter for Dag runs feat(ui,api): implement conf_contains filter refactor(ui): move trigering user filter into filterbar refactor: Simplify JSON type detection for filtering fix(i18n): modify triggering user translation * fix: resolve conflicts & move all filters into filterBar * test: Add test for duration and conf_contains filters test: modify duration test * fix(ui): Add icons and styled options to Dag runs select type filters fix(tests): Correct assignment in fixture fix: Correct tests for duration and conf_contains filters fix(test): using from_datetime_to_zulu_without_ms for end date fix(tests): Correct tuple assignment for in test setup * fix(tests): Correct datetime formatting and test expectations in dag_run API tests * fix(tests): Simplify conf_contains filter test patterns * test: using int for testing duration * fix(models): Make DagRun.duration property SQLite-compatible * fix(i18n): add duration translation keys
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
* feat(ui): implement filterbar for Dag run feat: add filter for dag Version feat(api): Add duration filter for Dag runs feat(ui): implement duration filter for Dag runs feat(ui,api): implement conf_contains filter refactor(ui): move trigering user filter into filterbar refactor: Simplify JSON type detection for filtering fix(i18n): modify triggering user translation * fix: resolve conflicts & move all filters into filterBar * test: Add test for duration and conf_contains filters test: modify duration test * fix(ui): Add icons and styled options to Dag runs select type filters fix(tests): Correct assignment in fixture fix: Correct tests for duration and conf_contains filters fix(test): using from_datetime_to_zulu_without_ms for end date fix(tests): Correct tuple assignment for in test setup * fix(tests): Correct datetime formatting and test expectations in dag_run API tests * fix(tests): Simplify conf_contains filter test patterns * test: using int for testing duration * fix(models): Make DagRun.duration property SQLite-compatible * fix(i18n): add duration translation keys
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
* feat(ui): implement filterbar for Dag run feat: add filter for dag Version feat(api): Add duration filter for Dag runs feat(ui): implement duration filter for Dag runs feat(ui,api): implement conf_contains filter refactor(ui): move trigering user filter into filterbar refactor: Simplify JSON type detection for filtering fix(i18n): modify triggering user translation * fix: resolve conflicts & move all filters into filterBar * test: Add test for duration and conf_contains filters test: modify duration test * fix(ui): Add icons and styled options to Dag runs select type filters fix(tests): Correct assignment in fixture fix: Correct tests for duration and conf_contains filters fix(test): using from_datetime_to_zulu_without_ms for end date fix(tests): Correct tuple assignment for in test setup * fix(tests): Correct datetime formatting and test expectations in dag_run API tests * fix(tests): Simplify conf_contains filter test patterns * test: using int for testing duration * fix(models): Make DagRun.duration property SQLite-compatible * fix(i18n): add duration translation keys
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
* feat(ui): implement filterbar for Dag run feat: add filter for dag Version feat(api): Add duration filter for Dag runs feat(ui): implement duration filter for Dag runs feat(ui,api): implement conf_contains filter refactor(ui): move trigering user filter into filterbar refactor: Simplify JSON type detection for filtering fix(i18n): modify triggering user translation * fix: resolve conflicts & move all filters into filterBar * test: Add test for duration and conf_contains filters test: modify duration test * fix(ui): Add icons and styled options to Dag runs select type filters fix(tests): Correct assignment in fixture fix: Correct tests for duration and conf_contains filters fix(test): using from_datetime_to_zulu_without_ms for end date fix(tests): Correct tuple assignment for in test setup * fix(tests): Correct datetime formatting and test expectations in dag_run API tests * fix(tests): Simplify conf_contains filter test patterns * test: using int for testing duration * fix(models): Make DagRun.duration property SQLite-compatible * fix(i18n): add duration translation keys
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
* feat(ui): implement filterbar for Dag run feat: add filter for dag Version feat(api): Add duration filter for Dag runs feat(ui): implement duration filter for Dag runs feat(ui,api): implement conf_contains filter refactor(ui): move trigering user filter into filterbar refactor: Simplify JSON type detection for filtering fix(i18n): modify triggering user translation * fix: resolve conflicts & move all filters into filterBar * test: Add test for duration and conf_contains filters test: modify duration test * fix(ui): Add icons and styled options to Dag runs select type filters fix(tests): Correct assignment in fixture fix: Correct tests for duration and conf_contains filters fix(test): using from_datetime_to_zulu_without_ms for end date fix(tests): Correct tuple assignment for in test setup * fix(tests): Correct datetime formatting and test expectations in dag_run API tests * fix(tests): Simplify conf_contains filter test patterns * test: using int for testing duration * fix(models): Make DagRun.duration property SQLite-compatible * fix(i18n): add duration translation keys
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
* feat(ui): implement filterbar for Dag run feat: add filter for dag Version feat(api): Add duration filter for Dag runs feat(ui): implement duration filter for Dag runs feat(ui,api): implement conf_contains filter refactor(ui): move trigering user filter into filterbar refactor: Simplify JSON type detection for filtering fix(i18n): modify triggering user translation * fix: resolve conflicts & move all filters into filterBar * test: Add test for duration and conf_contains filters test: modify duration test * fix(ui): Add icons and styled options to Dag runs select type filters fix(tests): Correct assignment in fixture fix: Correct tests for duration and conf_contains filters fix(test): using from_datetime_to_zulu_without_ms for end date fix(tests): Correct tuple assignment for in test setup * fix(tests): Correct datetime formatting and test expectations in dag_run API tests * fix(tests): Simplify conf_contains filter test patterns * test: using int for testing duration * fix(models): Make DagRun.duration property SQLite-compatible * fix(i18n): add duration translation keys
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Oct 12, 2025
* feat(ui): implement filterbar for Dag run feat: add filter for dag Version feat(api): Add duration filter for Dag runs feat(ui): implement duration filter for Dag runs feat(ui,api): implement conf_contains filter refactor(ui): move trigering user filter into filterbar refactor: Simplify JSON type detection for filtering fix(i18n): modify triggering user translation * fix: resolve conflicts & move all filters into filterBar * test: Add test for duration and conf_contains filters test: modify duration test * fix(ui): Add icons and styled options to Dag runs select type filters fix(tests): Correct assignment in fixture fix: Correct tests for duration and conf_contains filters fix(test): using from_datetime_to_zulu_without_ms for end date fix(tests): Correct tuple assignment for in test setup * fix(tests): Correct datetime formatting and test expectations in dag_run API tests * fix(tests): Simplify conf_contains filter test patterns * test: using int for testing duration * fix(models): Make DagRun.duration property SQLite-compatible * fix(i18n): add duration translation keys
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
* feat(ui): implement filterbar for Dag run feat: add filter for dag Version feat(api): Add duration filter for Dag runs feat(ui): implement duration filter for Dag runs feat(ui,api): implement conf_contains filter refactor(ui): move trigering user filter into filterbar refactor: Simplify JSON type detection for filtering fix(i18n): modify triggering user translation * fix: resolve conflicts & move all filters into filterBar * test: Add test for duration and conf_contains filters test: modify duration test * fix(ui): Add icons and styled options to Dag runs select type filters fix(tests): Correct assignment in fixture fix: Correct tests for duration and conf_contains filters fix(test): using from_datetime_to_zulu_without_ms for end date fix(tests): Correct tuple assignment for in test setup * fix(tests): Correct datetime formatting and test expectations in dag_run API tests * fix(tests): Simplify conf_contains filter test patterns * test: using int for testing duration * fix(models): Make DagRun.duration property SQLite-compatible * fix(i18n): add duration translation keys
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
* feat(ui): implement filterbar for Dag run feat: add filter for dag Version feat(api): Add duration filter for Dag runs feat(ui): implement duration filter for Dag runs feat(ui,api): implement conf_contains filter refactor(ui): move trigering user filter into filterbar refactor: Simplify JSON type detection for filtering fix(i18n): modify triggering user translation * fix: resolve conflicts & move all filters into filterBar * test: Add test for duration and conf_contains filters test: modify duration test * fix(ui): Add icons and styled options to Dag runs select type filters fix(tests): Correct assignment in fixture fix: Correct tests for duration and conf_contains filters fix(test): using from_datetime_to_zulu_without_ms for end date fix(tests): Correct tuple assignment for in test setup * fix(tests): Correct datetime formatting and test expectations in dag_run API tests * fix(tests): Simplify conf_contains filter test patterns * test: using int for testing duration * fix(models): Make DagRun.duration property SQLite-compatible * fix(i18n): add duration translation keys
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
* feat(ui): implement filterbar for Dag run feat: add filter for dag Version feat(api): Add duration filter for Dag runs feat(ui): implement duration filter for Dag runs feat(ui,api): implement conf_contains filter refactor(ui): move trigering user filter into filterbar refactor: Simplify JSON type detection for filtering fix(i18n): modify triggering user translation * fix: resolve conflicts & move all filters into filterBar * test: Add test for duration and conf_contains filters test: modify duration test * fix(ui): Add icons and styled options to Dag runs select type filters fix(tests): Correct assignment in fixture fix: Correct tests for duration and conf_contains filters fix(test): using from_datetime_to_zulu_without_ms for end date fix(tests): Correct tuple assignment for in test setup * fix(tests): Correct datetime formatting and test expectations in dag_run API tests * fix(tests): Simplify conf_contains filter test patterns * test: using int for testing duration * fix(models): Make DagRun.duration property SQLite-compatible * fix(i18n): add duration translation keys
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
* feat(ui): implement filterbar for Dag run feat: add filter for dag Version feat(api): Add duration filter for Dag runs feat(ui): implement duration filter for Dag runs feat(ui,api): implement conf_contains filter refactor(ui): move trigering user filter into filterbar refactor: Simplify JSON type detection for filtering fix(i18n): modify triggering user translation * fix: resolve conflicts & move all filters into filterBar * test: Add test for duration and conf_contains filters test: modify duration test * fix(ui): Add icons and styled options to Dag runs select type filters fix(tests): Correct assignment in fixture fix: Correct tests for duration and conf_contains filters fix(test): using from_datetime_to_zulu_without_ms for end date fix(tests): Correct tuple assignment for in test setup * fix(tests): Correct datetime formatting and test expectations in dag_run API tests * fix(tests): Simplify conf_contains filter test patterns * test: using int for testing duration * fix(models): Make DagRun.duration property SQLite-compatible * fix(i18n): add duration translation keys
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
closes: #53043
To-Do:
Test coverage:
test_dag_run.pyto verify newconf_contains&durationfiltersFilters:
range selectioncomponent would be a separate PR)triggeringUserNameFiltertranslation keysfilterBarProducing AssetScreenshots
conf.mp4
Follow up PR
number range,date range,tag^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.