Create an explicit control for createUserJob #56057
Merged
+58
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakharcode
requested review from
dstandish,
hussein-awala and
jedcunningham
as code owners
shahar1
changed the title
Contributor
Author
|
@hussein-awala can you take a look here ? |
Contributor
Author
|
@jedcunningham can you take a look here? |
Miretpl
suggested changes
Oct 16, 2025
Contributor
Miretpl
left a comment
Miretpl
left a comment
There was a problem hiding this comment.
Could you add a test case for it?
2 tasks
Contributor
Author
|
@Miretpl I will add a test for it today |
prakharcode
force-pushed
the
fix/i-51304
branch
from
373df71 to
1a70432
Compare
prakharcode
force-pushed
the
fix/i-51304
branch
from
1a70432 to
40057fc
Compare
Miretpl
approved these changes
Nov 25, 2025
Contributor
|
@prakharcode to me the change looks good now. @jedcunningham @hussein-awala @jscheffl could you take a look in a free moment? |
Contributor
Author
|
@Miretpl @jedcunningham @jscheffl can we move the PR forward? |
Contributor
|
@prakharcode I can't do much more really, cause I'm not able to merge the change to the repository. Just be patient till one of the PMC members takes a look. |
potiuk
approved these changes
Dec 7, 2025
amoghrajesh
pushed a commit
to astronomer/airflow
that referenced
this pull request
Dec 8, 2025
* [fix]: Creating an explicit control for createUserJob * added tests
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #51304
As describe in the issue, the createUserJob fails on the new standalone installation on helm.
This is because the createUserJob only checks in the setting for
defaultUser.enabledin webserver. This value check while being perfectly fine for older versions of airflow, created a bit of confusion for newer versions where you just putwebserver.enable: falseand expect nothing to be coupled with other deployments.Particularly, deployment trying to use simple_auth get an "unwanted" createUserJob which always fails.
To make the creation of
createUserJobexplicit, I have included another value which explicitly setsenabled: true | false.This should make things clear and init control (a bit) independent.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.