Fix multi-line drag selection in task log view #56238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brunda10
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
jscheffl
approved these changes
Sep 30, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Oh, thanks! Much smoother and better to select text now.
Seems some other PR merged and made a conflict - can you resolve and push a change?
Before merge would request another pair of eyes to double check that solution is the best approach as my CSS knowledge is limited.
bbovenzi
reviewed
Oct 1, 2025
airflow-core/src/airflow/ui/src/pages/TaskInstance/Logs/TaskLogContent.tsx
Outdated
Show resolved
Hide resolved
bbovenzi
approved these changes
Oct 1, 2025
bbovenzi
added
the
backport-to-v3-1-test
Contributor
|
CI failures are unrelated |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 1, 2025
(cherry picked from commit 5f8eff1) Co-authored-by: Brunda10 <brunda.n@zemosolabs.com> Co-authored-by: Brent Bovenzi <brent@astronomer.io>
Backport successfully created: v3-1-test
|
jscheffl
pushed a commit
that referenced
this pull request
Oct 1, 2025
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Oct 12, 2025
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
Co-authored-by: Brent Bovenzi <brent@astronomer.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes : #55879
Previously, dragging across multiple lines in the task log view caused the selection to jump back to the top of the logs, making it impossible to select multiple lines reliably. This was caused by the combination of
position: absoluteandtransform: translateY()on virtualized rows.This PR fixes the issue by:
transformproperty and relying solely ontopfor positioning.Users can now drag-select multiple lines smoothly, improving log readability and overall UX.
Screencast.from.2025-09-29.16-15-40.webm