Add is_favorite to ui dags list #56341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
requested review from
bugraoz93,
ephraimbuddy,
jason810496,
jscheffl,
pierrejeambrun,
rawwar,
ryanahamilton and
shubhamraj-git
as code owners
boring-cyborg
bot
added
area:API
jscheffl
approved these changes
Oct 2, 2025
jason810496
reviewed
Oct 3, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Nice! Thanks for the PR!
My nits are non-blocking.
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/dags.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/core_api/routes/ui/dags.py
Outdated
Show resolved
Hide resolved
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Looking good, just one suggestion
bbovenzi
force-pushed
the
add-is_favorite-to-ui-dags-response
branch
from
0276653 to
07b8fc4
Compare
bbovenzi
force-pushed
the
add-is_favorite-to-ui-dags-response
branch
from
07b8fc4 to
fe8d84a
Compare
jscheffl
approved these changes
Oct 9, 2025
bbovenzi
added
the
backport-to-v3-1-test
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Oct 9, 2025
* Add is_favorite to ui dags list * Update dagdetails (cherry picked from commit ba7b407) Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
* Add is_favorite to ui dags list * Update dagdetails
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
* Add is_favorite to ui dags list * Update dagdetails
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
* Add is_favorite to ui dags list * Update dagdetails
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Oct 12, 2025
* Add is_favorite to ui dags list * Update dagdetails
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
* Add is_favorite to ui dags list * Update dagdetails
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
* Add is_favorite to ui dags list * Update dagdetails
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
* Add is_favorite to ui dags list * Update dagdetails
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
* Add is_favorite to ui dags list * Update dagdetails
kaxil
pushed a commit
that referenced
this pull request
Oct 21, 2025
* Add is_favorite to ui dags list * Update dagdetails (cherry picked from commit ba7b407)
TyrellHaywood
pushed a commit
to TyrellHaywood/airflow
that referenced
this pull request
Oct 22, 2025
* Add is_favorite to ui dags list * Update dagdetails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue that favoriting a dag in the dags list would break the sorting of the dags page. That was because we were querying the dags list inside of each Favorite Dag button and it affected the dags list cache. Instead, we should juse include
is_favoriteon the Dag response.Also, make the Star icon stroke match the fill.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.