fix: enable api to clear ti instances by specifying map indexes #56346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think you need to rebase main, some of the CI tests are failing because of that. Also, it seems that the changes don't reference the |
kevinhongzl
force-pushed
the
api-support-clear-ti-by-map-index
branch
2 times, most recently
from
fc50916 to
08fd98c
Compare
Contributor
Author
|
Appreciate your comments and review @seanghaeli ! As I'm working on this issue, I also reviewed relevant PRs and discussions about clearing task instances in AF2 (#22958, #24699, #45349). Currently, we are clearing multiple mapped tasks by passing a list of tuples There is no However, your comments reminded me that it might be unclear for users how to include the map index when using this endpoint. I'll improve the descriptions and documentation as well. Thank you! |
kevinhongzl
force-pushed
the
api-support-clear-ti-by-map-index
branch
from
838e1ea to
5c4d8da
Compare
kevinhongzl
requested review from
ashb,
bbovenzi,
bolkedebruin,
bugraoz93,
ephraimbuddy,
jason810496,
jscheffl,
pierrejeambrun,
potiuk,
rawwar,
ryanahamilton and
shubhamraj-git
as code owners
jason810496
reviewed
Oct 5, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Thanks for the PR! I will talk a closer look for over all structure later.
airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py
Outdated
Show resolved
Hide resolved
pierrejeambrun
approved these changes
Oct 13, 2025
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
LGTM, just a few nits.
airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py
Outdated
Show resolved
Hide resolved
kevinhongzl
force-pushed
the
api-support-clear-ti-by-map-index
branch
4 times, most recently
from
8153adb to
16f8bf8
Compare
kevinhongzl
force-pushed
the
api-support-clear-ti-by-map-index
branch
from
16f8bf8 to
0223959
Compare
pierrejeambrun
added
the
backport-to-v3-1-test
airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py
Outdated
Show resolved
Hide resolved
pierrejeambrun
force-pushed
the
api-support-clear-ti-by-map-index
branch
from
461de61 to
56c6a84
Compare
pierrejeambrun
approved these changes
Oct 20, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Oct 21, 2025
…ndexes (#56346) * fix: enable api to clear ti instances by specifying map indexes * chore: add tests for clearing mapped task instances from api endpoint * chore: add descriptions to task_ids in the payload * fix: deal with tests that were broken when map_indexes was introduced * chore: generate datamodel and api spec * chore: rewrite clear task_ids for clarity and remove duplicate tasks * Small adjustments --------- (cherry picked from commit 800f733) Co-authored-by: Zhen-Lun (Kevin) Hong <zhenlun.hong01@gmail.com> Co-authored-by: pierrejeambrun <pierrejbrun@gmail.com>
Backport successfully created: v3-1-test
|
pierrejeambrun
added a commit
that referenced
this pull request
Oct 21, 2025
…ndexes (#56346) (#56945) * fix: enable api to clear ti instances by specifying map indexes * chore: add tests for clearing mapped task instances from api endpoint * chore: add descriptions to task_ids in the payload * fix: deal with tests that were broken when map_indexes was introduced * chore: generate datamodel and api spec * chore: rewrite clear task_ids for clarity and remove duplicate tasks * Small adjustments --------- (cherry picked from commit 800f733) Co-authored-by: Zhen-Lun (Kevin) Hong <zhenlun.hong01@gmail.com> Co-authored-by: pierrejeambrun <pierrejbrun@gmail.com>
Jonpaco23
pushed a commit
to Jonpaco23/airflow
that referenced
this pull request
Oct 21, 2025
…he#56346) * fix: enable api to clear ti instances by specifying map indexes * chore: add tests for clearing mapped task instances from api endpoint * chore: add descriptions to task_ids in the payload * fix: deal with tests that were broken when map_indexes was introduced * chore: generate datamodel and api spec * chore: rewrite clear task_ids for clarity and remove duplicate tasks * Small adjustments --------- Co-authored-by: pierrejeambrun <pierrejbrun@gmail.com>
Contributor
Author
|
@pierrejeambrun Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #56289 (also close #43635)
Why this change
This PR resolves the issue where the api endpoint
clearTaskInstancefails to operate on mapped TIs. Previously, there were cases that we could not clear mapped tasks individually even when their map indices were provided in payload.Solution
task_ids. This was the root cause of the failure to clear single mapped tasks.task_ids(i.e. how to include map indices to reference specific mapped task instances)^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.