let PubsubPullTrigger exceptions propagate to triggerer framework #56400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
jason810496
approved these changes
Oct 5, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Nice! Thanks for the PR!
Based on the context in the issue description, maybe we could create e issue for standardizing the TriggerEvent usage.
Contributor
Author
I can create one – though I’m also wondering if this behavior was actually intended. Maybe once the issue is open, others can share their thoughts. This change will likely affect all triggers across all providers |
MaksYermak
reviewed
Oct 6, 2025
providers/google/src/airflow/providers/google/cloud/triggers/pubsub.py
Outdated
Show resolved
Hide resolved
VladaZakharova
suggested changes
Oct 6, 2025
providers/google/src/airflow/providers/google/cloud/triggers/pubsub.py
Outdated
Show resolved
Hide resolved
potiuk
approved these changes
Oct 13, 2025
MaksYermak
approved these changes
Oct 14, 2025
Jonpaco23
pushed a commit
to Jonpaco23/airflow
that referenced
this pull request
Oct 21, 2025
…ache#56400) * fix: let PubsubPullTrigger exceptions propagate to triggerer framework * revert break statement to return
69 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PubsubPullTriggercaught exceptions and yielded error events, creating unwanted DAG runs for asset watchers when exceptions are thrown in the trigger.This fix is to let exceptions propagate to the triggerer framework, which handles them appropriately #54804 (comment)
PubsubPullTrigger.run()related: #54804
This fix also enables the Google Pub/Sub messaging queue feature #54494
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.