Add ability to disable apiserver from the helm chart using apiServer enabled #56493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluek1te
requested review from
dstandish,
hussein-awala and
jedcunningham
as code owners
2 tasks
Miretpl
suggested changes
Oct 16, 2025
Contributor
Miretpl
left a comment
Miretpl
left a comment
There was a problem hiding this comment.
In general change looks good! Could you also add test cases for it?
bluek1te
force-pushed
the
main
branch
2 times, most recently
from
d8985f8 to
c4b3dfe
Compare
Contributor
Author
|
Sure! Just added some tests |
Contributor
|
Change looks good to me, but some tests are failing. Could you take a look? |
amoghrajesh
reviewed
Oct 19, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Mostly looks good, some comments re quality checks and also the static checks are failing, could you look?
bluek1te
force-pushed
the
main
branch
2 times, most recently
from
cf430b3 to
6e02cc2
Compare
Contributor
Author
|
Resolved change requests and static checks are now passing. |
Miretpl
reviewed
Oct 20, 2025
Miretpl
approved these changes
Oct 21, 2025
Contributor
Miretpl
left a comment
Miretpl
left a comment
There was a problem hiding this comment.
Hi @dstandish @jedcunningham @hussein-awala @amoghrajesh could you take a look?
amoghrajesh
changed the title
amoghrajesh
approved these changes
Oct 22, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
nits regarding flipping the checks but otherwise looks good.
2 tasks
Contributor
Author
|
Can this be merged? |
jscheffl
approved these changes
Nov 19, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
I thnk it can. But let's have CI turning green.
aaron-wolmutt
pushed a commit
to aaron-wolmutt/airflow
that referenced
this pull request
Nov 20, 2025
…enabled (apache#56493) Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
Copilot AI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
…enabled (apache#56493) Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
…enabled (apache#56493) Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…enabled
From #56492, add the ability to disable the api server so that we can create a deployment that only creates workers (for remote execution with airflow 3.0+)