[v3-1-test] Fix task retries executing wrong method after deferred state (#56731) #56737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate (#56731) When a deferred task resumed and failed in its completion callback, retries would incorrectly re-execute the callback instead of restarting from the beginning. This caused retry attempts to fail repeatedly at the same step rather than attempting the full task execution from scratch. The fix ensures next_method and next_kwargs fields are properly cleared when tasks transition to retry, failed, or success states, preventing stale deferral parameters from persisting across task attempts. Fixes #56704 (cherry picked from commit 16e9b35) Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a deferred task resumed and failed in its completion callback,
retries would incorrectly re-execute the callback instead of restarting
from the beginning. This caused retry attempts to fail repeatedly at the
same step rather than attempting the full task execution from scratch.
The fix ensures next_method and next_kwargs fields are properly cleared
when tasks transition to retry, failed, or success states, preventing
stale deferral parameters from persisting across task attempts.
Fixes #56704
(cherry picked from commit 16e9b35)
Co-authored-by: Kaxil Naik kaxilnaik@gmail.com