[v3-1-test] Synchronize and fix ARM CI workflows (#56856) #56858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a few issues with ARM workflows: * not all jobs were run in ARM tests - we do not want to run mysql of course, but other tests should be fine to run on ARM * some conditions were not updated (we have to somehow duplicate amd and arm job definition because we run out of composite workflows - so sometimes conditions are not synced) * most importantly - we uploaded prek cache in build-info job, but that job only run on AMD, not on ARM so the ARM cache was really an AMD one (and it caused unterminated strings in doctoc installation It's not possible to upload same artifact twice in the same job and since we use prek in several jobs we should make sure that the cache is only uploaded once per job. This was the reason why it was initially uploaded in build-info job (and save-cache was set to false elsewhere). With this PR, we have save-cache in 3 places: * basic checks * static CI-image bound checks * in octopin (Python 3.11) Basic checks and static checks are mutually exclusive (controlled by basic-checks-only flag) - so we can safely upload cache in both. In all other places we only install prek with cache, but we do not save the cache as artifact. (cherry picked from commit 59089cd) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
potiuk
requested review from
amoghrajesh,
ashb,
bugraoz93,
eladkal,
gopidesupavan,
jason810496,
jscheffl,
kaxil and
potiuk
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few issues with ARM workflows:
of course, but other tests should be fine to run on ARM
amd and arm job definition because we run out of composite
workflows - so sometimes conditions are not synced)
that job only run on AMD, not on ARM so the ARM cache was really
an AMD one (and it caused unterminated strings in doctoc installation
It's not possible to upload same artifact twice in the same job and
since we use prek in several jobs we should make sure that the cache
is only uploaded once per job. This was the reason why it was initially
uploaded in build-info job (and save-cache was set to false elsewhere).
With this PR, we have save-cache in 3 places:
Basic checks and static checks are mutually exclusive (controlled by
basic-checks-only flag) - so we can safely upload cache in both.
In all other places we only install prek with cache, but we do not
save the cache as artifact.
(cherry picked from commit 59089cd)
Co-authored-by: Jarek Potiuk jarek@potiuk.com