-
Notifications
You must be signed in to change notification settings - Fork 16.4k
[v3-1-test] docs:improve plugin system documentation for clarity and completeness (#56177) #56985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…completeness (#56177) * docs:improve plugin system documentation for clarity and completeness * Apply suggestion from @kaxil * Review feedback Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com> --------- (cherry picked from commit e6e3370) Co-authored-by: Lohith M <152604836+Lohith625@users.noreply.github.com> Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com> Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com> Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
|
There are few more changes here than described in the PR - is it intentional? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and the rest seem like added accidentally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased I guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops yes, I accidentally hit "Update Branch". It's just a docs update. I can close this and manually backport
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs:improve plugin system documentation for clarity and completeness
Apply suggestion from @kaxil
Review feedback
Co-authored-by: Brent Bovenzi brent.bovenzi@gmail.com
(cherry picked from commit e6e3370)
Co-authored-by: Lohith M 152604836+Lohith625@users.noreply.github.com
Co-authored-by: Kaxil Naik kaxilnaik@gmail.com
Co-authored-by: Jens Scheffler 95105677+jscheffl@users.noreply.github.com
Co-authored-by: Brent Bovenzi brent.bovenzi@gmail.com