Fix grid links for tasks with retries #57063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierrejeambrun
requested review from
bbovenzi,
jscheffl,
ryanahamilton and
shubhamraj-git
as code owners
pierrejeambrun
added
the
backport-to-v3-1-test
eladkal
approved these changes
Oct 22, 2025
bbovenzi
reviewed
Oct 22, 2025
pierrejeambrun
force-pushed
the
fix-grid-link-for-tasks-with-retries
branch
from
1365e26 to
28a8cd9
Compare
pierrejeambrun
force-pushed
the
fix-grid-link-for-tasks-with-retries
branch
from
28a8cd9 to
00c8d56
Compare
bbovenzi
approved these changes
Oct 22, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Oct 22, 2025
* Fix grid links for tasks with retries * Update following code review (cherry picked from commit a8f2d97) Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Backport successfully created: v3-1-test
|
pierrejeambrun
added a commit
that referenced
this pull request
Oct 22, 2025
kaxil
pushed a commit
that referenced
this pull request
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #56977
It's super cool to keep search params when navigating between tasks in the grid, so we can keep log filtering (source, level etc...), but try_number should always be reseted. This will cause the UI to default to the latest try_number and prevent the issue reported #56977
(also moved the searchparams hook down to the GridTI component, we were passing those as prop for no reason)