Skip to content

Conversation

@alamashir
Copy link
Contributor

This commit addresses multiple bugs in systemd service files reported in issue #53706:

  1. Fix incorrect command in airflow-api.service

    • Changed 'airflow api' to 'airflow api-server' (correct CLI command)
  2. Standardize environment configuration approach

    • Changed airflow-api.service and airflow-triggerer.service to use EnvironmentFile=/etc/sysconfig/airflow instead of inline Environment
    • This provides consistency with other services and allows admins flexibility to manage custom environment variables centrally
  3. Fix service dependencies

    • Added proper After= and Wants= clauses for database and message queue services (postgresql, mysql, redis, rabbitmq) to airflow-api.service and airflow-triggerer.service
    • Services now wait for required dependencies before starting
  4. Additional bug fixes discovered during review

    • airflow-flower.service: Removed duplicate ExecStart line
    • airflow-kerberos.service: Fixed command from 'kerberos' to 'airflow kerberos'
  5. Consistency improvements

    • Added Type=simple and RestartSec=5s to airflow-api.service and airflow-triggerer.service for consistency with other services

All systemd service files now follow the same configuration pattern, making them easier to maintain and more reliable during system startup.

Fixes #53706


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

This commit addresses multiple bugs in systemd service files reported
in issue apache#53706:

1. Fix incorrect command in airflow-api.service
   - Changed 'airflow api' to 'airflow api-server' (correct CLI command)

2. Standardize environment configuration approach
   - Changed airflow-api.service and airflow-triggerer.service to use
     EnvironmentFile=/etc/sysconfig/airflow instead of inline Environment
   - This provides consistency with other services and allows admins
     flexibility to manage custom environment variables centrally

3. Fix service dependencies
   - Added proper After= and Wants= clauses for database and message
     queue services (postgresql, mysql, redis, rabbitmq) to
     airflow-api.service and airflow-triggerer.service
   - Services now wait for required dependencies before starting

4. Additional bug fixes discovered during review
   - airflow-flower.service: Removed duplicate ExecStart line
   - airflow-kerberos.service: Fixed command from 'kerberos' to
     'airflow kerberos'

5. Consistency improvements
   - Added Type=simple and RestartSec=5s to airflow-api.service and
     airflow-triggerer.service for consistency with other services

All systemd service files now follow the same configuration pattern,
making them easier to maintain and more reliable during system startup.

Fixes apache#53706
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 23, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Oct 23, 2025
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Interesting, from what I see this would have never worked.

I am not a systemd expert but from pure reading this looks like LGTM. Another pair of eyes might be good.

@potiuk potiuk merged commit b370160 into apache:main Oct 25, 2025
50 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 25, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

github-actions bot pushed a commit that referenced this pull request Oct 25, 2025
This commit addresses multiple bugs in systemd service files reported
in issue #53706:

1. Fix incorrect command in airflow-api.service
   - Changed 'airflow api' to 'airflow api-server' (correct CLI command)

2. Standardize environment configuration approach
   - Changed airflow-api.service and airflow-triggerer.service to use
     EnvironmentFile=/etc/sysconfig/airflow instead of inline Environment
   - This provides consistency with other services and allows admins
     flexibility to manage custom environment variables centrally

3. Fix service dependencies
   - Added proper After= and Wants= clauses for database and message
     queue services (postgresql, mysql, redis, rabbitmq) to
     airflow-api.service and airflow-triggerer.service
   - Services now wait for required dependencies before starting

4. Additional bug fixes discovered during review
   - airflow-flower.service: Removed duplicate ExecStart line
   - airflow-kerberos.service: Fixed command from 'kerberos' to
     'airflow kerberos'

5. Consistency improvements
   - Added Type=simple and RestartSec=5s to airflow-api.service and
     airflow-triggerer.service for consistency with other services

All systemd service files now follow the same configuration pattern,
making them easier to maintain and more reliable during system startup.

Fixes #53706
(cherry picked from commit b370160)

Co-authored-by: Ashir Alam <alamashir@gmail.com>
@github-actions
Copy link

Backport successfully created: v3-1-test

Status Branch Result
v3-1-test PR Link

potiuk pushed a commit that referenced this pull request Oct 25, 2025
This commit addresses multiple bugs in systemd service files reported
in issue #53706:

1. Fix incorrect command in airflow-api.service
   - Changed 'airflow api' to 'airflow api-server' (correct CLI command)

2. Standardize environment configuration approach
   - Changed airflow-api.service and airflow-triggerer.service to use
     EnvironmentFile=/etc/sysconfig/airflow instead of inline Environment
   - This provides consistency with other services and allows admins
     flexibility to manage custom environment variables centrally

3. Fix service dependencies
   - Added proper After= and Wants= clauses for database and message
     queue services (postgresql, mysql, redis, rabbitmq) to
     airflow-api.service and airflow-triggerer.service
   - Services now wait for required dependencies before starting

4. Additional bug fixes discovered during review
   - airflow-flower.service: Removed duplicate ExecStart line
   - airflow-kerberos.service: Fixed command from 'kerberos' to
     'airflow kerberos'

5. Consistency improvements
   - Added Type=simple and RestartSec=5s to airflow-api.service and
     airflow-triggerer.service for consistency with other services

All systemd service files now follow the same configuration pattern,
making them easier to maintain and more reliable during system startup.

Fixes #53706
(cherry picked from commit b370160)

Co-authored-by: Ashir Alam <alamashir@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Systemd scripts

3 participants