Make extra of Asset, AssetAlias, AssetEvent a dict[str, JsonValue]
#57352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
force-pushed
the
fix-asset-event-extra
branch
from
2433990 to
ae3654f
Compare
uranusjr
reviewed
Oct 28, 2025
uranusjr
reviewed
Oct 28, 2025
Member
Author
|
The nested dict works fine. The numpy thing doesn't. will mark it as ready once finished adding the tests |
Lee-W
force-pushed
the
fix-asset-event-extra
branch
from
2610c1e to
1dca60d
Compare
Lee-W
requested review from
XD-DENG,
amoghrajesh,
ashb,
bbovenzi,
bugraoz93,
ephraimbuddy,
jason810496,
jscheffl,
kaxil,
pierrejeambrun,
potiuk,
rawwar,
ryanahamilton and
shubhamraj-git
as code owners
Lee-W
changed the title
extra of Asset, AssetAlias, AssetEvent a dict[str, JsonValue]
Lee-W
added
the
backport-to-v3-1-test
jason810496
approved these changes
Oct 28, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Thanks for the PR! LGTM overall.
uranusjr
reviewed
Oct 28, 2025
Lee-W
force-pushed
the
fix-asset-event-extra
branch
2 times, most recently
from
a887544 to
92091b7
Compare
amoghrajesh
reviewed
Oct 28, 2025
airflow-core/src/airflow/api_fastapi/core_api/datamodels/assets.py
Outdated
Show resolved
Hide resolved
Lee-W
force-pushed
the
fix-asset-event-extra
branch
from
daec944 to
bce08ec
Compare
Lee-W
force-pushed
the
fix-asset-event-extra
branch
from
bce08ec to
753de58
Compare
2 tasks
Backport successfully created: v3-1-test
|
Lee-W
added a commit
to astronomer/airflow
that referenced
this pull request
Nov 3, 2025
…ict[str, JsonValue]` (apache#57352) (cherry picked from commit c25455e)
Lee-W
added a commit
that referenced
this pull request
Nov 3, 2025
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 3, 2025
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 4, 2025
2 tasks
44 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The original implementation fails when
extracontains non-hashable types (e.g., `dict``), even though such structures are valid JsonValue. This caused issues with comparing and registering asset events.Closes: #56882
What
extrainAsset,AssetAlias, andAssetEventto be typed asdict[str, JsonValue]to allow JSON-serializable data explicitly.extraas JSON for comparingextrabefore registering theAssetEventso that it can be correctly written to the database.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.