Skip to content

Revert virtualenv connections/variables access and logging as test are failing in CI#57475

Merged
ashb merged 1 commit intoapache:mainfrom
astronomer:revert-57213-virtualenv-connections-variables
Oct 29, 2025
Merged

Revert virtualenv connections/variables access and logging as test are failing in CI#57475
ashb merged 1 commit intoapache:mainfrom
astronomer:revert-57213-virtualenv-connections-variables

Conversation

@sunank200
Copy link
Collaborator

Revert virtualenv connections/variables access and logging as tests are failing in https://github.com/apache/airflow/actions/runs/18896380254. The issue here is that it's a socket initialisation error that occurs when CommsDecoder tries to create a socket from stdin (file descriptor 0) in subprocess environments where stdin is not a socket.

This reverts commit fb8b590 (PR #57213) which allowed virtualenv code to access connections/variables and send logs via supervisor comms reinitialization.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@sunank200 sunank200 requested a review from ashb October 29, 2025 09:10
@sunank200 sunank200 added the full tests needed We need to run full set of tests for this PR to merge label Oct 29, 2025
@ashb
Copy link
Member

ashb commented Oct 29, 2025

Static failure is unrelated to this test. Merging.

@ashb ashb merged commit 84e95b6 into apache:main Oct 29, 2025
111 of 112 checks passed
@ashb ashb deleted the revert-57213-virtualenv-connections-variables branch October 29, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers full tests needed We need to run full set of tests for this PR to merge provider:standard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants