Fix: Prevent AttributeError crash in prek when run inside container#57497
Merged
jscheffl merged 13 commits intoapache:mainfrom Oct 31, 2025
Merged
Fix: Prevent AttributeError crash in prek when run inside container#57497jscheffl merged 13 commits intoapache:mainfrom
jscheffl merged 13 commits intoapache:mainfrom
Conversation
…e failing Revert virtualenv connections/variables access and logging as tests are failing in https://github.com/apache/airflow/actions/runs/18896380254. The issue here is that it's a socket initialisation error that occurs when CommsDecoder tries to create a socket from stdin (file descriptor 0) in subprocess environments where stdin is not a socket. This reverts commit fb8b590 (PR apache#57213) which allowed virtualenv code to access connections/variables and send logs via supervisor comms reinitialization.
sanju1198
requested review from
amoghrajesh,
ashb,
bugraoz93,
eladkal,
gopidesupavan,
jason810496,
jscheffl,
kaxil and
potiuk
as code owners
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
boring-cyborg
bot
added
area:dev-tools
area:providers
backport-to-v3-1-test
Member
|
You should still print something using built-in |
potiuk
reviewed
Oct 29, 2025
Member
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
NICE! Thanks for the investigation and fix !
potiuk
approved these changes
Oct 29, 2025
Member
With the caveat that the comment from @uranusjr will be addressed. In this case indeed the problem is that ich is not importable, but print should work |
potiuk
reviewed
Oct 29, 2025
uranusjr
approved these changes
Oct 30, 2025
jscheffl
approved these changes
Oct 31, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Cool! Thanks for the fix!
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 31, 2025
… container (#57497) * Revert virtualenv connections/variables access and logging as test are failing Revert virtualenv connections/variables access and logging as tests are failing in https://github.com/apache/airflow/actions/runs/18896380254. The issue here is that it's a socket initialisation error that occurs when CommsDecoder tries to create a socket from stdin (file descriptor 0) in subprocess environments where stdin is not a socket. This reverts commit fb8b590 (PR #57213) which allowed virtualenv code to access connections/variables and send logs via supervisor comms reinitialization. * Address review: Use built-in print as fallback --------- (cherry picked from commit 5002660) Co-authored-by: Gurram Sai Ganesh <gurramsaiganesh93@gmail.com> Co-authored-by: Ankit Chaurasia <8670962+sunank200@users.noreply.github.com>
Backport successfully created: v3-1-test
|
jscheffl
pushed a commit
that referenced
this pull request
Oct 31, 2025
… container (#57497) (#57649) * Revert virtualenv connections/variables access and logging as test are failing Revert virtualenv connections/variables access and logging as tests are failing in https://github.com/apache/airflow/actions/runs/18896380254. The issue here is that it's a socket initialisation error that occurs when CommsDecoder tries to create a socket from stdin (file descriptor 0) in subprocess environments where stdin is not a socket. This reverts commit fb8b590 (PR #57213) which allowed virtualenv code to access connections/variables and send logs via supervisor comms reinitialization. * Address review: Use built-in print as fallback --------- (cherry picked from commit 5002660) Co-authored-by: Gurram Sai Ganesh <gurramsaiganesh93@gmail.com> Co-authored-by: Ankit Chaurasia <8670962+sunank200@users.noreply.github.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 3, 2025
… container (#57497) (#57649) * Revert virtualenv connections/variables access and logging as test are failing Revert virtualenv connections/variables access and logging as tests are failing in https://github.com/apache/airflow/actions/runs/18896380254. The issue here is that it's a socket initialisation error that occurs when CommsDecoder tries to create a socket from stdin (file descriptor 0) in subprocess environments where stdin is not a socket. This reverts commit fb8b590 (PR #57213) which allowed virtualenv code to access connections/variables and send logs via supervisor comms reinitialization. * Address review: Use built-in print as fallback --------- (cherry picked from commit 5002660) Co-authored-by: Gurram Sai Ganesh <gurramsaiganesh93@gmail.com> Co-authored-by: Ankit Chaurasia <8670962+sunank200@users.noreply.github.com>
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 4, 2025
… container (#57497) (#57649) * Revert virtualenv connections/variables access and logging as test are failing Revert virtualenv connections/variables access and logging as tests are failing in https://github.com/apache/airflow/actions/runs/18896380254. The issue here is that it's a socket initialisation error that occurs when CommsDecoder tries to create a socket from stdin (file descriptor 0) in subprocess environments where stdin is not a socket. This reverts commit fb8b590 (PR #57213) which allowed virtualenv code to access connections/variables and send logs via supervisor comms reinitialization. * Address review: Use built-in print as fallback --------- (cherry picked from commit 5002660) Co-authored-by: Gurram Sai Ganesh <gurramsaiganesh93@gmail.com> Co-authored-by: Ankit Chaurasia <8670962+sunank200@users.noreply.github.com>
Copilot AI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
…pache#57497) * Revert virtualenv connections/variables access and logging as test are failing Revert virtualenv connections/variables access and logging as tests are failing in https://github.com/apache/airflow/actions/runs/18896380254. The issue here is that it's a socket initialisation error that occurs when CommsDecoder tries to create a socket from stdin (file descriptor 0) in subprocess environments where stdin is not a socket. This reverts commit fb8b590 (PR apache#57213) which allowed virtualenv code to access connections/variables and send logs via supervisor comms reinitialization. * Address review: Use built-in print as fallback --------- Co-authored-by: Ankit Chaurasia <8670962+sunank200@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an
AttributeError: 'NoneType' object has no attribute 'print'that occurs when runningprekinside the Breeze shell.The
consoleobject isNonein a non-TTY environment, and this PR addsif console:checks to prevent the script from crashing whenconsole.print()is called.This fixes the bug I found in the #new-contributors Slack.