Improve tagging of providers when preparing a relase #57628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
amoghrajesh,
ashb,
bugraoz93,
eladkal,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl and
kaxil
as code owners
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
Tagging providers after release after apache#57337 happened after preparing the tarball - which was wrong :) as tarball uses the tag to build the -sources package. Also it cannot be done too early becasue tags are created based on the provider packages prepared in dist. So - tagging providers *SHOULD* happen between creating provider distributions and creating tarball. This PR moves creation of the tarball to the right place, it also improves a bit the "tag-providers" step: * it uses PACKAGE_DATE environment variable if it is defined * it does not react on existing tags - it simply overwrites the tags if such tags exist.
potiuk
force-pushed
the
move-tagging-providers-to-earlier-step
branch
from
384884f to
99dcac6
Compare
eladkal
approved these changes
Oct 31, 2025
eladkal
removed
the
backport-to-v3-1-test
Copilot AI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
Tagging providers after release after apache#57337 happened after preparing the tarball - which was wrong :) as tarball uses the tag to build the -sources package. Also it cannot be done too early becasue tags are created based on the provider packages prepared in dist. So - tagging providers *SHOULD* happen between creating provider distributions and creating tarball. This PR moves creation of the tarball to the right place, it also improves a bit the "tag-providers" step: * it uses PACKAGE_DATE environment variable if it is defined * it does not react on existing tags - it simply overwrites the tags if such tags exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tagging providers after release after #57337 happened after preparing the tarball - which was wrong :) as tarball uses the tag to build the -sources package. Also it cannot be done too early becasue tags are created based on the provider packages prepared in dist.
So - tagging providers SHOULD happen between creating provider distributions and creating tarball.
This PR moves creation of the tarball to the right place, it also improves a bit the "tag-providers" step:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.