-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Handle task timeouts at supervisor #57778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
e4e0db4 to
20d35b8
Compare
20d35b8 to
02eab9d
Compare
f1c0858 to
e4e9af9
Compare
70d47bd to
47b6145
Compare
47b6145 to
39b2c55
Compare
|
Hey @LeonardoIshida - are you going to continue working on it? |
|
There are some test failures that need at least rebase if not fixing. |
39b2c55 to
fdb2472
Compare
Hi, @potiuk, I am just waiting for a new review. And I will be working on this until it gets merged. |
|
I just ran your workflows (as a first time contributor your workflows need to be approved) - so it is yet to be seen if they are fixed. Generally getting the PR green is often a prerequisite for someone to take a look at it. And if you see failing tests - attempt to fix them (and as a first time contributor ping in the PR when you think you did - and rebased - so that the workflows can be run, rather than wait |
|
My bad, did not know about that. I see that there are some tests failling, going to take a look into those ones. Thanks for the help @potiuk. |
fdb2472 to
6da83f2
Compare
6da83f2 to
ea66ba2
Compare
ea66ba2 to
37676b9
Compare
|
Hi, can someone approve my workflow again, please? |
|
did |
|
Hey guys, my final exams are kicking in and I am afraid I will not be able to continue working on this PR and issue. |
closes #57777, closes #57174, closes #53337
Problem
Currently, task timeouts are handled using SIGALRM within the task process itself. This approach is bad because:
Solution
This PR moves timeout enforcement from the task process to the supervisor:
Changes
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.