Fix callback.data nullable mismatch between model and DB schema#57827
Closed
vincbeck wants to merge 1 commit intoapache:mainfrom
Closed
Fix callback.data nullable mismatch between model and DB schema#57827vincbeck wants to merge 1 commit intoapache:mainfrom
callback.data nullable mismatch between model and DB schema#57827vincbeck wants to merge 1 commit intoapache:mainfrom
Conversation
Contributor
|
This was my mistake 😅 I changed |
Contributor
|
I created this PR: 57836 |
ferruzzi
requested changes
Nov 5, 2025
Contributor
ferruzzi
left a comment
ferruzzi
left a comment
There was a problem hiding this comment.
Commenting to block accidental merge. See Ramit's comments above.
uranusjr
previously approved these changes
Nov 5, 2025
Contributor
Author
|
Closing this one in favor of #57836 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The model property
datafromcallbackmismatches its DB schema definition. This property should be nullable. This is reported by the testtest_database_schema_and_sqlalchemy_model_are_in_syncwhen SQLA2 is used. This test is failing in #56212 and I fixed it and now cherry-picking from there.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.