-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Removed unused parameter in logout #58045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6a43028 to
391f4a4
Compare
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok - BUT - this is touching the "stable" API. Even though 99% used only for UI, is this a breaking change where we need to keep the unused param for compatibility? How is you are using an "old" client with generated code against the previous API spec? The call would fail with excess parameters? Or will excess parameters be accepted?
airflow-core/src/airflow/api_fastapi/core_api/openapi/v2-rest-api-generated.yaml
Show resolved
Hide resolved
That's a good call but this parameter is also not used so ... I do not know. Let's hear what others think |
I think extra parameters specified in URL are simply ignored by FastAPI (to be checked) so technically speaking this is not a breaking change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup!
I think extra parameters specified in URL are simply ignored by FastAPI (to be checked) so technically speaking this is not a breaking change.
Yes, this PR isn't a breaking change IMO.
Actually #56633 is kind of the breaking change for user because we replace the frontend side Cookie with HTTP-only Cookie. ( Some contributors reported that they need to clear the browser cache after #56633 had merged, but it should not be a big problem for users)
391f4a4 to
f8a6bcd
Compare
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.