Move SDK callback definitions to a separate callback module#58177
Merged
potiuk merged 1 commit intoapache:mainfrom Nov 18, 2025
Merged
Conversation
ramitkataria
requested review from
amoghrajesh,
ashb and
kaxil
as code owners
Member
|
You might need to rebase your PRs after fixing main. |
Followup to apache#54796. Since callbacks are going to be independent from deadlines, we might as well move them to their own module. I've essentially copied the code between files with the only actual change being imports and switching to structlog.
ramitkataria
force-pushed
the
ramitkataria/deadlines/move-callback-sdk-new-module
branch
from
5bb7206 to
ec31b25
Compare
o-nikolas
approved these changes
Nov 17, 2025
ramitkataria
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Nov 20, 2025
Callback definitions in TaskSDK were moved to their own module in apache#58177 but updating the docs about that change was missed.
aaron-wolmutt
pushed a commit
to aaron-wolmutt/airflow
that referenced
this pull request
Nov 20, 2025
…8177) Followup to apache#54796. Since callbacks are going to be independent from deadlines, we might as well move them to their own module. I've essentially copied the code between files with the only actual change being imports and switching to structlog.
ramitkataria
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Dec 4, 2025
Callback definitions in TaskSDK were moved to their own module in apache#58177 causing existing Dags using `AsyncCallback` to fail. Using lazy imports ensure that Dag authors are shielded from these types of changes in the future.
Copilot AI
pushed a commit
to jason810496/airflow
that referenced
this pull request
Dec 5, 2025
…8177) Followup to apache#54796. Since callbacks are going to be independent from deadlines, we might as well move them to their own module. I've essentially copied the code between files with the only actual change being imports and switching to structlog.
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
…8177) Followup to apache#54796. Since callbacks are going to be independent from deadlines, we might as well move them to their own module. I've essentially copied the code between files with the only actual change being imports and switching to structlog.
ramitkataria
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jan 21, 2026
Callback definitions in TaskSDK were moved to their own module in apache#58177 causing existing Dags using `AsyncCallback` to fail. Using lazy imports ensure that Dag authors are shielded from these types of changes in the future.
ramitkataria
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jan 21, 2026
Callback definitions in TaskSDK were moved to their own module in apache#58177 causing existing Dags using `AsyncCallback` to fail. Using lazy imports ensure that Dag authors are shielded from these types of changes in the future.
ramitkataria
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jan 21, 2026
Callback definitions in TaskSDK were moved to their own module in apache#58177 causing existing Dags using `AsyncCallback` to fail. Using lazy imports ensure that Dag authors are shielded from these types of changes in the future.
ferruzzi
pushed a commit
that referenced
this pull request
Jan 22, 2026
Callback definitions in TaskSDK were moved to their own module in #58177 causing existing Dags using `AsyncCallback` to fail. Using lazy imports ensure that Dag authors are shielded from these types of changes in the future.
suii2210
pushed a commit
to suii2210/airflow
that referenced
this pull request
Jan 26, 2026
) Callback definitions in TaskSDK were moved to their own module in apache#58177 causing existing Dags using `AsyncCallback` to fail. Using lazy imports ensure that Dag authors are shielded from these types of changes in the future.
shreyas-dev
pushed a commit
to shreyas-dev/airflow
that referenced
this pull request
Jan 29, 2026
) Callback definitions in TaskSDK were moved to their own module in apache#58177 causing existing Dags using `AsyncCallback` to fail. Using lazy imports ensure that Dag authors are shielded from these types of changes in the future.
jhgoebbert
pushed a commit
to jhgoebbert/airflow
that referenced
this pull request
Feb 4, 2026
) Callback definitions in TaskSDK were moved to their own module in apache#58177 causing existing Dags using `AsyncCallback` to fail. Using lazy imports ensure that Dag authors are shielded from these types of changes in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #54796. Since callbacks are going to be independent from deadlines, we might as well move them to their own module.
I've essentially copied the code between files with the only actual change being imports and switching to structlog.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.