-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Create DAGNode in Core #59194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create DAGNode in Core #59194
Conversation
c54d91a to
84c6caa
Compare
84c6caa to
a227e96
Compare
Which tests for example ? |
|
For example This test really just tests |
2f7e6e3 to
2164a6a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
2164a6a to
b3c86fb
Compare
b3c86fb to
3ad044b
Compare
I think those tests should remain as they are - they are testing effectively integration of the methods with actual instances of Dag/Task for example. I think however we could have mocked versions of the classes that would not be created by Dag/ / make_tests instantitaiton but simply using MagicMock objects with spec ? |
9259187 to
12d9687
Compare
12d9687 to
a138458
Compare
|
Redoing this in #59708. |
This handles the DAGNode part for #52141.
Logic shared by both SDK and Core is implemented in a shared library. The shared class is implemented as a Generic, with concrete types (DAG, TaskGroup, etc.) supplied in Core and Task SDK.
I’m not sure what to do with tests… The functionalities are currently covered in SDK or Core tests. Do we pull them to the shared library? That would require us to add quite some code to stub out the concrete types that are unavailable in
_shared.