Clean up SDK references in airflow.models.expandinput #59815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is never called anywhere in the SDK. The implementation has been copied to Core, which actually uses the logic. The NotMapped exception has also been removed (there's a copy in Core that Core function raise).
These are simply not needed, and we should remove them to avoid accidental usages.
These are now raised in entirely unrelated places and each can now be its own class.
uranusjr
requested review from
amoghrajesh,
ashb,
bolkedebruin and
kaxil
as code owners
uranusjr
force-pushed
the
core-expandinput
branch
from
318d25f to
ec6f492
Compare
20 tasks
uranusjr
force-pushed
the
core-expandinput
branch
from
ec6f492 to
7b89ff0
Compare
This is currently not used anywhere in the scheduler, but properly encoding would allow this value to display better in UI. Before this, a MappedArgument object is simply casted to a string.
uranusjr
force-pushed
the
core-expandinput
branch
from
7b89ff0 to
2650077
Compare
kaxil
approved these changes
Dec 26, 2025
amoghrajesh
pushed a commit
to astronomer/airflow
that referenced
this pull request
Dec 29, 2025
Subham-KRLX
pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Jan 2, 2026
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these are not used anymore after the Greate Split. The one remaining class (not actually used in scheduler logic currently) is also now properly encoded.
See #52141.