-
Notifications
You must be signed in to change notification settings - Fork 16.8k
Add description about Gen-AI contributions to our guide #60158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
fdbfd4b
Add description about Gen-AI contributions to our guide
potiuk 9008ee9
Update contributing-docs/05_pull_requests.rst
potiuk 1606c71
fixup! Update contributing-docs/05_pull_requests.rst
potiuk b72829e
Update contributing-docs/05_pull_requests.rst
potiuk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,44 +1,37 @@ | ||
| <!-- | ||
| Licensed to the Apache Software Foundation (ASF) under one | ||
| or more contributor license agreements. See the NOTICE file | ||
| distributed with this work for additional information | ||
| regarding copyright ownership. The ASF licenses this file | ||
| to you under the Apache License, Version 2.0 (the | ||
| "License"); you may not use this file except in compliance | ||
| with the License. You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, | ||
| software distributed under the License is distributed on an | ||
| "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| KIND, either express or implied. See the License for the | ||
| specific language governing permissions and limitations | ||
| under the License. | ||
| --> | ||
| Thank you for contributing! | ||
|
|
||
| <!-- | ||
| Thank you for contributing! Please make sure that your code changes | ||
| are covered with tests. And in case of new features or big changes | ||
| remember to adjust the documentation. | ||
| Please provide above a brief description of the changes made in this pull request. | ||
| Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/ | ||
|
|
||
| Please make sure that your code changes are covered with tests. | ||
| And in case of new features or big changes remember to adjust the documentation. | ||
|
|
||
| Feel free to ping committers for the review! | ||
| Feel free to ping (in general) for the review if you do not see reaction for a few days | ||
amoghrajesh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications. | ||
|
|
||
| In case of an existing issue, reference it using one of the following: | ||
|
|
||
| closes: #ISSUE | ||
| related: #ISSUE | ||
| * closes: #ISSUE | ||
| * related: #ISSUE | ||
| --> | ||
|
|
||
| ## Was generative AI tooling used to co-author this PR? | ||
amoghrajesh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| How to write a good git commit message: | ||
| http://chris.beams.io/posts/git-commit/ | ||
| <!-- | ||
| If generative AI tooling has been used in the process of authoring this PR, please | ||
| change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". | ||
| --> | ||
|
|
||
| - [ ] Yes (please specify the tool below) | ||
potiuk marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| <!-- | ||
| Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) | ||
o-nikolas marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| --> | ||
|
|
||
| <!-- Please keep an empty line above the dashes. --> | ||
| --- | ||
| **^ Add meaningful description above** | ||
| Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. | ||
| In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. | ||
| In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). | ||
| In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). | ||
|
|
||
| * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. | ||
| * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. | ||
| * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). | ||
| * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.