Add checks for allshared modules referred in pyproject.toml #60211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
amoghrajesh
approved these changes
Jan 7, 2026
potiuk
force-pushed
the
add-dagnode-shared-module
branch
from
5e8a84b to
cfb185d
Compare
potiuk
requested review from
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl and
kaxil
as code owners
potiuk
changed the title
Member
Author
|
It turns out we also miss plugins manager -> I added automated checks and fixing in the pre-commit to prevent it from happening again, |
amoghrajesh
reviewed
Jan 7, 2026
potiuk
force-pushed
the
add-dagnode-shared-module
branch
3 times, most recently
from
28422ac to
752f7e4
Compare
amoghrajesh
approved these changes
Jan 7, 2026
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
Looks fine now! Didnt check in detail but it does the job and doesn't look off
The apache#59708 missed adding dagnode to workspace. Also it turned out that we have plugins manager missing in similar way. This PR adds a check and automated fix to make sure it won't happen again and adds missing distributions to pyproject.toml.
potiuk
force-pushed
the
add-dagnode-shared-module
branch
from
752f7e4 to
af83897
Compare
Member
Author
|
I also asked Claude to refactor the recent changes and remove duplication it introduced. It did the job nicely :) |
chirodip98
pushed a commit
to chirodip98/airflow-contrib
that referenced
this pull request
Jan 9, 2026
…0211) The apache#59708 missed adding dagnode to workspace. Also it turned out that we have plugins manager missing in similar way. This PR adds a check and automated fix to make sure it won't happen again and adds missing distributions to pyproject.toml.
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
…0211) The apache#59708 missed adding dagnode to workspace. Also it turned out that we have plugins manager missing in similar way. This PR adds a check and automated fix to make sure it won't happen again and adds missing distributions to pyproject.toml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #59708 missed adding dagnode to workspace. Also it turned out
that we have plugins manager missing in similar way.
This PR adds a check and automated fix to make sure it won't
happen again and adds missing distributions to pyproject.toml.
Generated-By: Claude Sonnet 4.5 following the guidelines
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.