Skip to content

Conversation

@Miretpl
Copy link
Contributor

@Miretpl Miretpl commented Jan 7, 2026

related: #28880

This PR introduces a new workers.celery.persistence section and deprecates the old workers.persistence section (as it was only applicable to Celery workers).

Despite adding a new section, the following things were done:

  1. Simplification of persistence-related test cases in test_hpa.py and test_keda.py
  2. Addition of missing tests in test_worker.py for workers.persistence.size and workers.persistence.fixPermissions fields
  3. Removed unused should_filter parameter in test_keda.py::test_keda_query_kubernetes_queue test

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@Miretpl Miretpl marked this pull request as ready for review January 7, 2026 22:10
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, wow, this is a bigger one! Thanks!

@jscheffl jscheffl merged commit 1adb1c6 into apache:main Jan 8, 2026
173 of 176 checks passed
@Miretpl Miretpl deleted the add-workers-celery-persistance branch January 8, 2026 21:45
@Miretpl
Copy link
Contributor Author

Miretpl commented Jan 8, 2026

Yeah, to be honest, I was thinking that persistence section has fewer dependencies 😆

stegololz pushed a commit to stegololz/airflow that referenced this pull request Jan 9, 2026
* Rewrite persistence hpa & keda tests

* Add workers.celery.persistence section

* Add missing test cases for worker persistence

* Update NOTES.txt and add newsfragment

* Fix misc
@jscheffl jscheffl added this to the Airflow Helm Chart 1.19.0 milestone Jan 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants