fix(chart): allow revisionHistoryLimit to be set to 0 #60340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use explicit nil check instead of truthy check to allow 0 as valid value. Signed-off-by: Angel Freire <cuerty@gmail.com>
cuerty
requested review from
dstandish,
hussein-awala,
jedcunningham and
jscheffl
as code owners
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
…onHistoryLimit helper The previous implementation compared $result with "" using eq, which fails when $result is assigned an integer value (like 0) because Go templates don't allow comparing different types. Fixed by using a boolean $found flag instead of type-unsafe string comparison. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
jason810496
pushed a commit
to jason810496/airflow
that referenced
this pull request
Jan 22, 2026
* fix(chart): allow revisionHistoryLimit to be set to 0 Use explicit nil check instead of truthy check to allow 0 as valid value. Signed-off-by: Angel Freire <cuerty@gmail.com> * fix(chart): use boolean flag to avoid type comparison error in revisionHistoryLimit helper The previous implementation compared $result with "" using eq, which fails when $result is assigned an integer value (like 0) because Go templates don't allow comparing different types. Fixed by using a boolean $found flag instead of type-unsafe string comparison. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> --------- Signed-off-by: Angel Freire <cuerty@gmail.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, setting
revisionHistoryLimit: 0was silently ignored becausethe templates used a truthy check which evaluates 0 as false.
Changed to explicit nil check via a new
_set_if_not_nilhelper to allow 0 as a valid value.closes: #60339
Was generative AI tooling used to co-author this PR?
Generated-by: Claude following the guidelines
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.