-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Made WinRMOperator deferrable #60651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dabla
wants to merge
122
commits into
apache:main
Choose a base branch
from
dabla:feature/deferrable-winrm-operator
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+583
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d, then retry one more time before failing
… it was never used anyway and use standard execution_timeout parameter instead
…tor common test util method so it really executes the operator and tests the deferred as well so we can directly assert the returned result and yielded events
…il the trigger fast with failed trigger event
24c92bf to
6566908
Compare
kaxil
reviewed
Jan 30, 2026
| username=self.username, | ||
| password=self.password, | ||
| service=self.service, | ||
| keytab=self.keytab, # type: ignore |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# type: ignore :) We should avoid them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was generative AI tooling used to co-author this PR?
Motivation
Recently, we encountered an issue where TaskInstances were being prematurely killed by the scheduler.
We initially tried the fix proposed in PR #60330 made by @ephraimbuddy, but unfortunately this did not help in our case. After further investigation, we discovered that this behaviour only occurred in DAGs using the WinRMOperator.
Problem
We use the WinRMOperator to launch remote processes on Windows servers. Some of these processes can take a significant amount of time to complete.
The root cause is that the WinRMOperator currently performs polling synchronously inside the worker, via the run method of WinRMHook. This has several drawbacks:
Overall, this is not an efficient or scalable execution model in Airflow.
Solution
This PR refactors the WinRMOperator to support deferrable execution.
When deferrable=True:
This aligns the WinRMOperator with Airflow’s recommended architecture for long-running or polling-based operations.
Benefits
Workers are no longer blocked by long-running WinRM commands.
Example Usage
Conclussion
With this refactoring in place, we no longer experience TaskInstances being prematurely killed. Polling is handled asynchronously by the triggerer, which is the preferred and more robust approach for this type of workload in Airflow and we don't block workers for polling unnecessarily.
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.