Skip to content

Conversation

@guan404ming
Copy link
Member

@guan404ming guan404ming commented Jan 18, 2026

Related PR

#60652

Why

The with open() block closed the file handle immediately after Popen() returned, killing the Vite servers' stdout.

How

Move Popen() outside the with block and open the file separately in append mode.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: [Claude Code] following the guidelines


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Jan 18, 2026
@potiuk potiuk merged commit ea0c8ef into apache:main Jan 18, 2026
60 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 18, 2026
(cherry picked from commit ea0c8ef)

Co-authored-by: Guan-Ming (Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
@github-actions
Copy link

Backport successfully created: v3-1-test

Status Branch Result
v3-1-test PR Link

@guan404ming guan404ming deleted the fix-dev-mode-vite-servers branch January 18, 2026 12:17
github-actions bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Jan 18, 2026
(cherry picked from commit ea0c8ef)

Co-authored-by: Guan-Ming (Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
@guan404ming
Copy link
Member Author

Thanks!

amoghrajesh pushed a commit that referenced this pull request Jan 19, 2026
)

(cherry picked from commit ea0c8ef)

Co-authored-by: Guan-Ming (Wesley) Chiu <105915352+guan404ming@users.noreply.github.com>
jason810496 pushed a commit to jason810496/airflow that referenced this pull request Jan 22, 2026
shreyas-dev pushed a commit to shreyas-dev/airflow that referenced this pull request Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants