Merged
Conversation
acf4f73 to
227fdf7
Compare
227fdf7 to
10aa040
Compare
potiuk
approved these changes
Jan 27, 2026
shreyas-dev
pushed a commit
to shreyas-dev/airflow
that referenced
this pull request
Jan 29, 2026
shashbha14
pushed a commit
to shashbha14/airflow
that referenced
this pull request
Feb 2, 2026
jason810496
pushed a commit
to abhijeets25012-tech/airflow
that referenced
this pull request
Feb 3, 2026
jhgoebbert
pushed a commit
to jhgoebbert/airflow
that referenced
this pull request
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
The
test_executiontest is flaky due to a race condition. When the worker raises the intendedRuntimeError, it crashes, causing the LocalExecutor to immediately respawn a new worker to maintain parallelism.This creates an infinite crash-and-respawn loop if the new worker picks up the failing task again. As a result,
executor.end()hangs (times out) because it cannot successfully join the processes while new ones are constantly being spawned.How:
I introduced a
has_failed_onceflag to ensure the worker raises theRuntimeErroronly once. Subsequent executions will return successfully. This prevents the infinite respawn loop, allowing the worker to shut down gracefully andexecutor.end()to finish without timing out.closes: #45329
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.