Add team to list variables and list connections pages #60995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincbeck
requested review from
bbovenzi,
bugraoz93,
choo121600,
ephraimbuddy,
guan404ming,
jason810496,
pierrejeambrun,
rawwar,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
boring-cyborg
bot
added
area:API
o-nikolas
approved these changes
Jan 23, 2026
vincbeck
force-pushed
the
vincbeck/fix_mt_selector
branch
from
14509e5 to
79ea3cd
Compare
Comment on lines
+130
to
+135
| if (multiTeam) { | ||
| columns.splice(6, 0, { | ||
| accessorKey: "team_name", | ||
| header: translate("columns.team"), | ||
| }); | ||
| } |
Member
There was a problem hiding this comment.
Thanks for the PR.
We tend to never mutate objects because react diffing algorithm will compare references and not render the update if the object was mutated in place.
This is why you see a lot of:
const newArray = [...oldArray, ,newItem]
Here we are outside of a react component so it should be fine. (a new columns object is created on every render anyway)
Member
There was a problem hiding this comment.
#61123 Small adjustment so people do not copy/past this by mistake. (even if it's fine in this current form it could easily bait someone working on a similar component)
shreyas-dev
pushed a commit
to shreyas-dev/airflow
that referenced
this pull request
Jan 29, 2026
shashbha14
pushed a commit
to shashbha14/airflow
that referenced
this pull request
Feb 2, 2026
jason810496
pushed a commit
to abhijeets25012-tech/airflow
that referenced
this pull request
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add team as column to list variable and list connection pages. I add it only if the multi-team mode is enabled.
Plus, I found out several bugs when I was testing edit variable and connection. I fix these bugs as part of this PR as well.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.