Repair k8 async connection getter #61138
Merged
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
async connection generation was moved to a common module which uses the BaseHook's implementation of get_connection which will obviously not include any implementation that the child classes have in their get_connection methods. The kubernetes hook has some special handling in it's get_connection method. This handling is added one layer higher so that it is still present in the new call path.
o-nikolas
requested review from
hussein-awala,
jedcunningham and
jscheffl
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
Contributor
Author
ferruzzi
approved these changes
Jan 27, 2026
ramitkataria
approved these changes
Jan 27, 2026
Contributor
ramitkataria
left a comment
ramitkataria
left a comment
There was a problem hiding this comment.
Thanks! Should we add a unit test? Otherwise looks good to me
85 tasks
shreyas-dev
pushed a commit
to shreyas-dev/airflow
that referenced
this pull request
Jan 29, 2026
async connection generation was moved to a common module which uses the BaseHook's implementation of get_connection which will obviously not include any implementation that the child classes have in their get_connection methods. The kubernetes hook has some special handling in it's get_connection method. This handling is added one layer higher so that it is still present in the new call path.
shashbha14
pushed a commit
to shashbha14/airflow
that referenced
this pull request
Feb 2, 2026
async connection generation was moved to a common module which uses the BaseHook's implementation of get_connection which will obviously not include any implementation that the child classes have in their get_connection methods. The kubernetes hook has some special handling in it's get_connection method. This handling is added one layer higher so that it is still present in the new call path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in #56791 async connection generation was moved to a common module which uses the BaseHook's implementation of get_connection which will obviously not include any implementation that the child classes have in their get_connection methods. The kubernetes hook has some special handling in it's get_connection method. This handling is added one layer higher so that it is still present in the new call path.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.