Skip to content

Conversation

@amoghrajesh
Copy link
Contributor


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Cursor IDE with claude sonnet 4.5

This is a follow up to: #61118, where deadline references needed to be better handled.

In this PR, I intend to complete the migration of deadline alert references from airflow-core to task-sdk. task SDK now contains lightweight reference definitions for DAG authoring, while core retains database aware evaluation logic.

Changes of Note

  1. SDK: Added Lightweight ReferenceModels

Added reference classes with serialization only logic:

  • BaseDeadlineReference - Base class with serialize_reference() / deserialize_reference()
  • FixedDatetimeDeadline, DagRunLogicalDateDeadline, DagRunQueuedAtDeadline, AverageRuntimeDeadline
  • Added _evaluate_with() stub (raises NotImplementedError) to support custom references
  1. In airlfow-core, removed the ReferenceModels class but with __getattr__ redirect

  2. SerializedReferenceModels stays in core with full database logic - no changes made there.

Sanity Run


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant