[AIRFLOW-3753] Replace Flask-OAuthlib with Authlib

[lepture]

Make sure you have checked all steps below.

Jira

• My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
  • https://issues.apache.org/jira/browse/AIRFLOW-3753

Description

• Here are some details about my PR, including screenshots of any UI changes:

Flask-OAuthlib is deprecated, use Authlib instead. Updated Google and GitHub Enterprise OAuth backends.

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

• My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters (not including Jira issue reference)
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

Documentation

• In case of new functionality, my PR adds documentation that describes how to use it.
  • All the public functions and the classes in the PR contain docstrings that explain what it does
  • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

[codecov-io]

Codecov Report

Merging #6140 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #6140      +/-   ##
==========================================
+ Coverage   80.02%   80.02%   +<.01%     
==========================================
  Files         607      607              
  Lines       35032    35041       +9     
==========================================
+ Hits        28034    28042       +8     
- Misses       6998     6999       +1

Impacted Files	Coverage Δ
airflow/contrib/auth/backends/google_auth.py	0% <0%> (ø)	⬆️
...ow/contrib/auth/backends/github_enterprise_auth.py	0% <0%> (ø)	⬆️
airflow/utils/dag_processing.py	58.8% <0%> (-0.19%)	⬇️
airflow/jobs/backfill_job.py	91.43% <0%> (+1.52%)	⬆️
airflow/jobs/local_task_job.py	90% <0%> (+5%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ad1544...1016311. Read the comment docs.

[potiuk]

I like the change. What worries me a bit is that there are no tests covering the functionality. I don't think there are tests covering the original oauthlib but maybe that's an opportunity to introduce some tests - mocking the behaviour of the oauth ?

[potiuk]

I think it should be renamed to "oauth" :)

[lepture]

Can I change this name? It was named flask_oauth.

[lepture]

@potiuk It will take me some time to figure out how to write tests for airflow. Maybe in next week.

[potiuk]

Hey @lepture - will you have chance to work on it soon :) ?

[lepture]

@potiuk I'm afraid that I don't have time right now to figure out how to write the tests.

[potiuk]

Ok. I see and understand. Maybe I will try to take a look at that then :).

[lepture]

@potiuk if there is an example that would help a lot. I can't find any similar tests.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.