Skip to content

Conversation

@ashb
Copy link
Member

@ashb ashb commented Sep 30, 2019

Make sure you have checked all steps below.

Jira

  • No Jira

Description

  • Update the template alembic uses for creating migrations to pass (or at least be closer to passing) pylint checks

@ashb ashb requested review from mik-laj and potiuk September 30, 2019 09:09
@codecov-io
Copy link

codecov-io commented Sep 30, 2019

Codecov Report

Merging #6216 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6216      +/-   ##
==========================================
- Coverage   80.02%   80.01%   -0.02%     
==========================================
  Files         610      610              
  Lines       35176    35176              
==========================================
- Hits        28151    28147       -4     
- Misses       7025     7029       +4
Impacted Files Coverage Δ
airflow/contrib/operators/ssh_operator.py 82.5% <0%> (-1.25%) ⬇️
airflow/utils/dag_processing.py 56.37% <0%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 844bbad...bd98130. Read the comment docs.

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Should we split it to two separate commits? Filtering out of Flask Appbuilder tables should be separate commit I think.

@ashb
Copy link
Member Author

ashb commented Sep 30, 2019

Nit: Should we split it to two separate commits? Filtering out of Flask Appbuilder tables should be separate commit I think.

Good call, will do as two separate PRs. Done, other PR #6221

@ashb ashb force-pushed the alembic-templates branch from b8c58fa to bd98130 Compare October 1, 2019 09:48
@ashb ashb merged commit 3a90d78 into apache:master Oct 1, 2019
@ashb ashb deleted the alembic-templates branch October 1, 2019 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants