Skip to content

Run DB check only for core components in prod entrypoint#63413

Open
shaealh wants to merge 2 commits intoapache:mainfrom
shaealh:shaealh/60271-entrypoint-db-gating
Open

Run DB check only for core components in prod entrypoint#63413
shaealh wants to merge 2 commits intoapache:mainfrom
shaealh:shaealh/60271-entrypoint-db-gating

Conversation

@shaealh
Copy link
Contributor

@shaealh shaealh commented Mar 12, 2026

Closes #60271

Restrict entrypoint DB check to scheduler, dag-processor, triggerer, and api-server. Skip DB check for worker/task/interactive commands to avoid direct metadata DB dependency in worker pods.

@boring-cyborg boring-cyborg bot added area:dev-tools area:production-image Production image improvements and fixes backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Mar 12, 2026
@potiuk
Copy link
Member

potiuk commented Mar 12, 2026

Very nice ! Thank you :)

@potiuk
Copy link
Member

potiuk commented Mar 12, 2026

Let's see if CI agrees :D

@potiuk
Copy link
Member

potiuk commented Mar 12, 2026

Somethig wrong - likely the check is somewhat wrong - the logs of failing tests can be downloaded as artifacts @shaealh

@potiuk potiuk marked this pull request as draft March 12, 2026 12:06
@potiuk
Copy link
Member

potiuk commented Mar 12, 2026

@shaealh This PR has been converted to draft because it does not yet meet our Pull Request quality criteria.

Issues found:

  • Kubernetes tests: Failing: Kubernetes tests / K8S System:KubernetesExecutor-3.10-v1.30.13-true, Kubernetes tests / K8S System:KubernetesExecutor-3.10-v1.30.13-false, Kubernetes tests / K8S System:CeleryExecutor-3.10-v1.30.13-true, Kubernetes tests / K8S System:CeleryExecutor-3.10-v1.30.13-false, Kubernetes tests / K8S System:LocalExecutor-3.10-v1.30.13-true (+1 more). See the K8s testing documentation. See Kubernetes tests docs.

Note: Your branch is 6 commits behind main. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results.

What to do next:

  • The comment informs you what you need to do.
  • Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed.
  • Maintainers will then proceed with a normal review.

Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. If you have questions, feel free to ask on the Airflow Slack.

@shaealh shaealh force-pushed the shaealh/60271-entrypoint-db-gating branch from c41712d to 2b96661 Compare March 13, 2026 03:46
@shaealh shaealh marked this pull request as ready for review March 13, 2026 05:39
@shaealh
Copy link
Contributor Author

shaealh commented Mar 13, 2026

Thank you @potiuk, fixed the issue and marked the PR as "Ready for review"

@shaealh shaealh force-pushed the shaealh/60271-entrypoint-db-gating branch from 1e796ef to 4bd735c Compare March 14, 2026 04:17
@shaealh
Copy link
Contributor Author

shaealh commented Mar 14, 2026

Cannot merge, need reviewer to confirm and merge

@eladkal eladkal force-pushed the shaealh/60271-entrypoint-db-gating branch from a36c7c3 to a12a3e0 Compare March 26, 2026 08:22
@eladkal eladkal added this to the Airflow 3.1.9 milestone Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools area:production-image Production image improvements and fixes backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

k8 executor worker pod connecting to metadata db in Airflow 3

3 participants