Skip to content

Conversation

@ratb3rt
Copy link
Contributor

@ratb3rt ratb3rt commented Nov 14, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5781
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@turbaszek
Copy link
Member

I think the CI should work after #6596 is merged.

@codecov-io
Copy link

codecov-io commented Nov 18, 2019

Codecov Report

Merging #6588 into master will decrease coverage by 0.21%.
The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6588      +/-   ##
==========================================
- Coverage   83.69%   83.47%   -0.22%     
==========================================
  Files         650      651       +1     
  Lines       37427    37431       +4     
==========================================
- Hits        31325    31247      -78     
- Misses       6102     6184      +82
Impacted Files Coverage Δ
airflow/contrib/hooks/aws_firehose_hook.py 0% <0%> (-100%) ⬇️
airflow/providers/amazon/aws/hooks/kinesis.py 100% <100%> (ø)
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 77.14% <0%> (-21.43%) ⬇️
airflow/configuration.py 89.13% <0%> (-3.63%) ⬇️
airflow/jobs/scheduler_job.py 74.96% <0%> (+1.19%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd6a950...c89adf5. Read the comment docs.

@potiuk potiuk merged commit baae140 into apache:master Nov 18, 2019
@ratb3rt ratb3rt deleted the AIRFLOW-5781 branch November 19, 2019 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants