-
Notifications
You must be signed in to change notification settings - Fork 16.4k
[AIRFLOW-6046] Fix Alembic migrations & sync it to 1.10.* #6642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I have tested it with: mkdir airflow_templ
export AIRFLOW_HOME=~/airflow_templ
mkvirtualenv airflow_templ
workon airflow_templ
pip install apache-airflow
workon airflow_templ
which airflow # Confirm Airflow Version
airflow initdb
pip install -U -e . # Update to Airflow master
which airflow # Confirm Airflow Version
airflow version
airflow db upgradeOur original report is @mattinbits . Can you please test the upgrade with this PR @mattinbits too ? |
|
I can but unfortunately it might take a few days- I was testing this in the office and will be back there Tuesday |
|
OK, I managed to test it. Using the same approach with running alembic directly. Looks good to me. |
Thanks for confirming, have a nice weekend. |
Codecov Report
@@ Coverage Diff @@
## master #6642 +/- ##
==========================================
- Coverage 83.72% 83.24% -0.49%
==========================================
Files 672 672
Lines 37567 37567
==========================================
- Hits 31454 31273 -181
- Misses 6113 6294 +181
Continue to review full report at Codecov.
|
ashb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
Thanks for picking this up @kaxil 👍 |
Make sure you have checked all steps below.
Jira
Description
From [AIRFLOW-5771] Straighten out alembic migrations #6442 (comment)
just tried doing an upgrade to 1.10.6 followed by an upgrade to master:
Result is
Tests
Commits
Documentation